From patchwork Tue Jul 21 07:40:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinay Simha B N X-Patchwork-Id: 6832641 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9C2B4C05AC for ; Tue, 21 Jul 2015 07:40:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ADCA1205E9 for ; Tue, 21 Jul 2015 07:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4B2D205DF for ; Tue, 21 Jul 2015 07:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbbGUHkg (ORCPT ); Tue, 21 Jul 2015 03:40:36 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34740 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbbGUHke (ORCPT ); Tue, 21 Jul 2015 03:40:34 -0400 Received: by pacan13 with SMTP id an13so116005293pac.1; Tue, 21 Jul 2015 00:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6Pz8EVwt5IfLfqVtkE/O23Pm5kXd1qp8NZWV0pAl3Kk=; b=FiSAmpX6AwtnKjqeH7NFSLy1ch9SEnML/fpDKVVCNdAq1dvhD9BzXpEGQF66SChmel klHGUAGbeZDex13hwqwhykIU5fDabDqRXM7FRi6cL7DkpOw0urbvP4cllKi0dI6bm+aB rvEQyf1nkx8nIdUbD9KPMeGo7zey++534jv6+8r+sD1OC3cDTLsDDM7Ur70LLudCvd75 NrPcYsPVBWCnPTSkVtD26U//QGq1ejX8cuCKq0yKzDnzHS+k0wbVr9WQ8DcS3LBwY2DV aPwocZhrxwYWj7jB4XQfZeBvzacLDEYxZZuaNFGHs1zsmpoH4PSVYFWOADADg5ZlYWx9 8usQ== X-Received: by 10.66.146.100 with SMTP id tb4mr70201985pab.70.1437464433432; Tue, 21 Jul 2015 00:40:33 -0700 (PDT) Received: from localhost.localdomain ([202.83.17.75]) by smtp.gmail.com with ESMTPSA id oq10sm8746431pdb.75.2015.07.21.00.40.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Jul 2015 00:40:32 -0700 (PDT) From: Vinay Simha BN Cc: Vinay Simha BN , Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org (open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER), devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2 Date: Tue, 21 Jul 2015 13:10:01 +0530 Message-Id: <1437464402-18451-2-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1437464402-18451-1-git-send-email-simhavcs@gmail.com> References: <1437461084-17565-1-git-send-email-simhavcs@gmail.com> <1437464402-18451-1-git-send-email-simhavcs@gmail.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP --- drivers/staging/sm750fb/sm750_accel.h | 30 ++++++++++++++++++++---------- drivers/staging/sm750fb/sm750_help.h | 23 +---------------------- 2 files changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h index da067a0..c56fa99 100644 --- a/drivers/staging/sm750fb/sm750_accel.h +++ b/drivers/staging/sm750fb/sm750_accel.h @@ -259,12 +259,18 @@ unsigned int height, /* width and height of rectangle in pixel value */ unsigned int rop2); int hw_imageblit(struct lynx_accel *accel, - const char *pSrcbuf, /* pointer to start of source - buffer in system memory */ - u32 srcDelta, /* Pitch value (in bytes) of the source buffer, - +ive means top down and -ive mean button up */ - u32 startBit, /* Mono data can start at any bit in a byte, - this value should be 0 to 7 */ + const char *pSrcbuf, /* + * pointer to start of source + * buffer in system memory + */ + u32 srcDelta, /* + * Pitch value (in bytes) of the source buffer, + * +ive means top down and -ive mean button up + */ + u32 startBit, /* + * Mono data can start at any bit in a byte, + * this value should be 0 to 7 + */ u32 dBase, /* Address of destination: offset in frame buffer */ u32 dPitch, /* Pitch value of destination surface in BYTE */ u32 bytePerPixel, /* Color depth of destination surface */ @@ -272,9 +278,13 @@ int hw_imageblit(struct lynx_accel *accel, u32 dy, /* Starting coordinate of destination surface */ u32 width, u32 height, /* width and height of rectange in pixel value */ - u32 fColor, /* Foreground color (corresponding to a 1 in the - monochrome data */ - u32 bColor, /* Background color (corresponding to a 0 in the - monochrome data */ + u32 fColor, /* + * Foreground color (corresponding to a 1 in the + * monochrome data + */ + u32 bColor, /* + * Background color (corresponding to a 0 in the + * monochrome data + */ u32 rop2); #endif diff --git a/drivers/staging/sm750fb/sm750_help.h b/drivers/staging/sm750fb/sm750_help.h index 43d700b..c9378e2 100644 --- a/drivers/staging/sm750fb/sm750_help.h +++ b/drivers/staging/sm750fb/sm750_help.h @@ -1,7 +1,7 @@ #ifndef LYNX_HELP_H__ #define LYNX_HELP_H__ -/* FIELD MACROS */ +/* FIELD MACROS */ #define _LSB(f) (0 ? f) #define _MSB(f) (1 ? f) #define _COUNT(f) (_MSB(f) - _LSB(f) + 1) @@ -46,27 +46,6 @@ ~ _F_MASK(reg ## _ ## field) \ ) -/* Field Macros */ -#define FIELD_START(field) (0 ? field) -#define FIELD_END(field) (1 ? field) -#define FIELD_SIZE(field) (1 + FIELD_END(field) - \ - FIELD_START(field)) -#define FIELD_MASK(field) (((1 << (FIELD_SIZE(field)-1)) \ - | ((1 << (FIELD_SIZE(field)-1)) - 1)) \ - << FIELD_START(field)) -#define FIELD_NORMALIZE(reg, field) (((reg) & FIELD_MASK(field)) >> \ - FIELD_START(field)) -#define FIELD_DENORMALIZE(field, value) (((value) << FIELD_START(field)) & \ - FIELD_MASK(field)) - -#define FIELD_INIT(reg, field, value) FIELD_DENORMALIZE(reg ## _ ## field, \ - reg ## _ ## field ## _ ## value) -#define FIELD_INIT_VAL(reg, field, value) \ - (FIELD_DENORMALIZE(reg ## _ ## field, value)) -#define FIELD_VAL_SET(x, r, f, v) x = x & ~FIELD_MASK(r ## _ ## f) \ - | FIELD_DENORMALIZE(r ## _ ## f, \ - r ## _ ## f ## _ ## v) - #define RGB(r, g, b) \ ( \ (unsigned long) (((r) << 16) | ((g) << 8) | (b)) \