| Message ID | 1438506593-31845-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/08/15 12:09, Geert Uytterhoeven wrote: > The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is > not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer > functionality only, can still be compiled if GPIOLIB is not enabled. > > Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where > appropriate. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > --- > v2: > - Add Acked-by. > --- > drivers/video/fbdev/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 2d98de535e0f7374..569803f533d1a600 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2464,7 +2464,7 @@ config FB_SSD1307 > tristate "Solomon SSD1307 framebuffer support" > depends on FB && I2C > depends on OF > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > select FB_SYS_FOPS > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > Applied to 4.3 fbdev. I do wonder why this is needed, though... I understand COMPILE_TEST if the dependency in question is difficult/impossible to enable with your kernel config (say, enabling OMAP SoC support with x86 config), but isn't GPIOLIB something that can be trivially enabled in any kernel config? Tomi
Hi Tomi, On Tue, Aug 11, 2015 at 9:22 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 02/08/15 12:09, Geert Uytterhoeven wrote: >> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is >> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer >> functionality only, can still be compiled if GPIOLIB is not enabled. >> >> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where >> appropriate. >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> > Applied to 4.3 fbdev. Thanks! > I do wonder why this is needed, though... I understand COMPILE_TEST if > the dependency in question is difficult/impossible to enable with your > kernel config (say, enabling OMAP SoC support with x86 config), but > isn't GPIOLIB something that can be trivially enabled in any kernel config? While there are a few mfd and pinctrl drivers that select GPIOLIB, the presence of GPIOLIB is mostly a platform feature. Not all architectures support GPIOLIB yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 2d98de535e0f7374..569803f533d1a600 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2464,7 +2464,7 @@ config FB_SSD1307 tristate "Solomon SSD1307 framebuffer support" depends on FB && I2C depends on OF - depends on GPIOLIB + depends on GPIOLIB || COMPILE_TEST select FB_SYS_FOPS select FB_SYS_FILLRECT select FB_SYS_COPYAREA