| Message ID | 1439799056-16509-1-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/08/15 11:10, Christoph Hellwig wrote:
> Make sparse happy:
Well, I think someone will anyway be unhappy:
- memset_io() is used to clear fb_virt.
- fb_virt is assigned to fbdev->info.screen_base.
I don't know if it's better or worse to have the __iomem in ocfb.c...
Tomi
diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c index de98196..97f11d2 100644 --- a/drivers/video/fbdev/ocfb.c +++ b/drivers/video/fbdev/ocfb.c @@ -62,7 +62,7 @@ struct ocfb_dev { int little_endian; /* Physical and virtual addresses of framebuffer */ dma_addr_t fb_phys; - void __iomem *fb_virt; + void *fb_virt; u32 pseudo_palette[PALETTE_SIZE]; };
Make sparse happy: drivers/video/fbdev/ocfb.c:375:64: sparse: incorrect type in argument 3 (different address spaces) Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/video/fbdev/ocfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)