| Message ID | 1439826777-11489-1-git-send-email-yuriy.kolerov@synopsys.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov <yuriy.kolerov@synopsys.com> wrote: > Architectures which support VGA console must define screen_info > structurture from "uapi/linux/screen_info.h". Otherwise undefined > symbol error occurs. Usually it's defined in "setup.c" for each > architecture. > > If an architecture does not support VGA console (ARC's case) > there are 2 ways: define a dummy instance of screen_info or add > a negative dependency for VGA_CONSOLE in to prevent selecting > this option. > > I've implemented the second way. However the best solution is to > add HAVE_VGA_CONSOLE option for targets which support VGA > console. Then turn off VGA_CONSOLE by default and add dependency > to HAVE_VGA_CONSOLE. But right now it's better to just add a > negative dependency for ARC and then consider how to collaborate > about this issue with maintainers of other architectures. +1 > Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote: > On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov > <yuriy.kolerov@synopsys.com> wrote: >> Architectures which support VGA console must define screen_info >> structurture from "uapi/linux/screen_info.h". Otherwise undefined >> symbol error occurs. Usually it's defined in "setup.c" for each >> architecture. >> >> If an architecture does not support VGA console (ARC's case) >> there are 2 ways: define a dummy instance of screen_info or add >> a negative dependency for VGA_CONSOLE in to prevent selecting >> this option. >> >> I've implemented the second way. However the best solution is to >> add HAVE_VGA_CONSOLE option for targets which support VGA >> console. Then turn off VGA_CONSOLE by default and add dependency >> to HAVE_VGA_CONSOLE. But right now it's better to just add a >> negative dependency for ARC and then consider how to collaborate >> about this issue with maintainers of other architectures. > +1 > >> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Hi Tomi, Is anything else needed for this to be merged. Thx, -Vineet > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25/08/15 10:47, Vineet Gupta wrote: > On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote: >> On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov >> <yuriy.kolerov@synopsys.com> wrote: >>> Architectures which support VGA console must define screen_info >>> structurture from "uapi/linux/screen_info.h". Otherwise undefined >>> symbol error occurs. Usually it's defined in "setup.c" for each >>> architecture. >>> >>> If an architecture does not support VGA console (ARC's case) >>> there are 2 ways: define a dummy instance of screen_info or add >>> a negative dependency for VGA_CONSOLE in to prevent selecting >>> this option. >>> >>> I've implemented the second way. However the best solution is to >>> add HAVE_VGA_CONSOLE option for targets which support VGA >>> console. Then turn off VGA_CONSOLE by default and add dependency >>> to HAVE_VGA_CONSOLE. But right now it's better to just add a >>> negative dependency for ARC and then consider how to collaborate >>> about this issue with maintainers of other architectures. >> +1 >> >>> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Hi Tomi, > > Is anything else needed for this to be merged. This is already in linux-next, merged by Andrew Morton. Tomi
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index fe1cd01..5d27ba0 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -9,7 +9,7 @@ config VGA_CONSOLE depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \ !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \ (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ - !ARM64 + !ARM64 && !ARC default y help Saying Y here will allow you to use Linux in text mode through a
Architectures which support VGA console must define screen_info structurture from "uapi/linux/screen_info.h". Otherwise undefined symbol error occurs. Usually it's defined in "setup.c" for each architecture. If an architecture does not support VGA console (ARC's case) there are 2 ways: define a dummy instance of screen_info or add a negative dependency for VGA_CONSOLE in to prevent selecting this option. I've implemented the second way. However the best solution is to add HAVE_VGA_CONSOLE option for targets which support VGA console. Then turn off VGA_CONSOLE by default and add dependency to HAVE_VGA_CONSOLE. But right now it's better to just add a negative dependency for ARC and then consider how to collaborate about this issue with maintainers of other architectures. Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com> --- drivers/video/console/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)