From patchwork Thu Aug 20 06:52:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yalin wang X-Patchwork-Id: 7041051 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 469849F372 for ; Thu, 20 Aug 2015 06:53:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74FD920328 for ; Thu, 20 Aug 2015 06:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87EEB20320 for ; Thu, 20 Aug 2015 06:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbbHTGw7 (ORCPT ); Thu, 20 Aug 2015 02:52:59 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35675 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbbHTGw7 (ORCPT ); Thu, 20 Aug 2015 02:52:59 -0400 Received: by pacdd16 with SMTP id dd16so12969020pac.2; Wed, 19 Aug 2015 23:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=PxwSTLtk7AcJdvocA+74dt0ksKdkOVWjNiRWwEnQPq4=; b=v9n+FfDWXI7VcMHdTSOSjtwTAs2woKzJO63kGorRdpYIW81MLOj5UpPS910fN8K5un /u9PJK+lfZzxKrxvTXXYkGeBWDTv/zXK2EOQ2iUk5By0KFDzszY9lbw789gEtTKzBp6E KXnK4kkUzUbEeeRIPMhJTdSxV0FR8xTQFvIacByyLUeSZJVARnMdFmh5ek7ApD+PPyyt QwwjOFxlVbX+utjwVd0poMiluOuhQKd1OnMckVUHv1m5O9dx0rlNMl5z+O5CLXHpkd3q rjq/VeGo3MXEF+5A+LJITOfoXKYjsueQmLA++D4JRnyEEi3lUkcKnkDGBTI7I2vqFFdK NutA== X-Received: by 10.66.142.166 with SMTP id rx6mr3419812pab.25.1440053578533; Wed, 19 Aug 2015 23:52:58 -0700 (PDT) Received: from ubuntu.localdomain ([17.87.20.100]) by smtp.googlemail.com with ESMTPSA id h16sm3096908pdk.4.2015.08.19.23.52.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Aug 2015 23:52:57 -0700 (PDT) From: yalin wang To: adaplas@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: yalin wang Subject: [RFC] fbdev/nvidia:change reverse_order() macro Date: Thu, 20 Aug 2015 14:52:27 +0800 Message-Id: <1440053547-24193-1-git-send-email-yalin.wang2010@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This change reverse_order() to swab32(bitrev32()), so that it can have better performance on some platforms. Signed-off-by: yalin wang --- drivers/video/fbdev/nvidia/nv_accel.c | 4 ++-- drivers/video/fbdev/nvidia/nv_local.h | 13 ++++--------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_accel.c b/drivers/video/fbdev/nvidia/nv_accel.c index ad6472a..c21cb34 100644 --- a/drivers/video/fbdev/nvidia/nv_accel.c +++ b/drivers/video/fbdev/nvidia/nv_accel.c @@ -382,7 +382,7 @@ static void nvidiafb_mono_color_expand(struct fb_info *info, for (j = RECT_EXPAND_TWO_COLOR_DATA_MAX_DWORDS; j--;) { tmp = data[k++]; - reverse_order(&tmp); + tmp = reverse_order(tmp); NVDmaNext(par, tmp); } @@ -394,7 +394,7 @@ static void nvidiafb_mono_color_expand(struct fb_info *info, for (j = dsize; j--;) { tmp = data[k++]; - reverse_order(&tmp); + tmp = reverse_order(tmp); NVDmaNext(par, tmp); } } diff --git a/drivers/video/fbdev/nvidia/nv_local.h b/drivers/video/fbdev/nvidia/nv_local.h index 68e508d..a0eb1f3 100644 --- a/drivers/video/fbdev/nvidia/nv_local.h +++ b/drivers/video/fbdev/nvidia/nv_local.h @@ -97,18 +97,13 @@ #ifdef __LITTLE_ENDIAN +#include #include -#define reverse_order(l) \ -do { \ - u8 *a = (u8 *)(l); \ - a[0] = bitrev8(a[0]); \ - a[1] = bitrev8(a[1]); \ - a[2] = bitrev8(a[2]); \ - a[3] = bitrev8(a[3]); \ -} while(0) +#define reverse_order(v) swab32(bitrev32(v)) + #else -#define reverse_order(l) do { } while(0) +#define reverse_order(v) (v) #endif /* __LITTLE_ENDIAN */ #endif /* __NV_LOCAL_H__ */