| Message ID | 1450610002-10531-3-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 20/12/15 13:13, Uwe Kleine-König wrote: > Some displays have a reset input. To assert that the display is > functional the reset gpio must be deasserted. > > Teach the driver to get and drive such a gpio accordingly. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > -- > Changes since (implicit) v1, sent with > Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org : > > - never assert reset because there are too many different panels with > too many different needs for their reset. > - split out dt binding changes > - reword commit log Please add these extra texts below the --- line below. Otherwise they end up in the commit description. > --- > drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c > index e780fd4f8b46..201a1c1a6f42 100644 > --- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c > +++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c > @@ -213,6 +213,16 @@ static int panel_dpi_probe_of(struct platform_device *pdev) > > ddata->enable_gpio = gpio; > > + /* > + * Many different panels are supported by this driver and there are > + * probably very different needs for their reset pins in regards to > + * timing and order relative to the enable gpio. So for now it's just > + * ensured that the reset line isn't active. > + */ > + gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(gpio)) > + return PTR_ERR(gpio); > + > ddata->backlight_gpio = -ENOENT; > > r = of_get_display_timing(node, "panel-timing", &timing); >
On Tue, Feb 16, 2016 at 03:01:55PM +0200, Tomi Valkeinen wrote: > > On 20/12/15 13:13, Uwe Kleine-König wrote: > > Some displays have a reset input. To assert that the display is > > functional the reset gpio must be deasserted. > > > > Teach the driver to get and drive such a gpio accordingly. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > -- > > Changes since (implicit) v1, sent with > > Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org : > > > > - never assert reset because there are too many different panels with > > too many different needs for their reset. > > - split out dt binding changes > > - reword commit log > > Please add these extra texts below the --- line below. Otherwise they > end up in the commit description. This was an accident. Should I resend for that one? Best regards Uwe -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16/02/16 15:31, Uwe Kleine-König wrote: > On Tue, Feb 16, 2016 at 03:01:55PM +0200, Tomi Valkeinen wrote: >> >> On 20/12/15 13:13, Uwe Kleine-König wrote: >>> Some displays have a reset input. To assert that the display is >>> functional the reset gpio must be deasserted. >>> >>> Teach the driver to get and drive such a gpio accordingly. >>> >>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >>> -- >>> Changes since (implicit) v1, sent with >>> Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org : >>> >>> - never assert reset because there are too many different panels with >>> too many different needs for their reset. >>> - split out dt binding changes >>> - reword commit log >> >> Please add these extra texts below the --- line below. Otherwise they >> end up in the commit description. > > This was an accident. Should I resend for that one? If there are other changes to other patches, resend the series. If there are no other changes, I can just snip it out. Tomi
diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c index e780fd4f8b46..201a1c1a6f42 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c @@ -213,6 +213,16 @@ static int panel_dpi_probe_of(struct platform_device *pdev) ddata->enable_gpio = gpio; + /* + * Many different panels are supported by this driver and there are + * probably very different needs for their reset pins in regards to + * timing and order relative to the enable gpio. So for now it's just + * ensured that the reset line isn't active. + */ + gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(gpio)) + return PTR_ERR(gpio); + ddata->backlight_gpio = -ENOENT; r = of_get_display_timing(node, "panel-timing", &timing);
Some displays have a reset input. To assert that the display is functional the reset gpio must be deasserted. Teach the driver to get and drive such a gpio accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Changes since (implicit) v1, sent with Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org : - never assert reset because there are too many different panels with too many different needs for their reset. - split out dt binding changes - reword commit log --- drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++++++++ 1 file changed, 10 insertions(+)