From patchwork Tue Jan 26 14:48:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Merello X-Patchwork-Id: 8123721 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7D7649F6DA for ; Tue, 26 Jan 2016 14:48:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B24AC20270 for ; Tue, 26 Jan 2016 14:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9F8420220 for ; Tue, 26 Jan 2016 14:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966070AbcAZOsU (ORCPT ); Tue, 26 Jan 2016 09:48:20 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36650 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965934AbcAZOsT (ORCPT ); Tue, 26 Jan 2016 09:48:19 -0500 Received: by mail-wm0-f66.google.com with SMTP id l65so17755147wmf.3 for ; Tue, 26 Jan 2016 06:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ccp2KukkM8+wHu2kQWfi+DKZk5NTp7qsk/1DG+W4Uho=; b=xJesLwpqlG+fIy8iZ3hJOHxVK3pNFRCD8UaoLAE0NBDfrbNMXbNCfJs/vZODZSM67s WB75kIypXQOGUU7cbhdT8nsB98KeBP8NqXQN1cpjQaLtCvyOI7bhG1SILa8ZaR8y0YRt uS727HaukY6ShBMvsD/dYqG2fHP+1JG6OpHUzw2mQtzB4lhx7gi6oLW8/bfNAuDxZPh0 uuio8tpcqBa7DC9t4jhvxND5Bg3wGdne6dU9XnwM2lR3O+xUiqjrzuIDBorbPgzGmPwi 2aNKr9NvNUO4n8XIWUSD1z04Qn9vKiBQHl8fHHWE2bla+DmvW8hBDe2zBbZQXWIM6Qcb J1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ccp2KukkM8+wHu2kQWfi+DKZk5NTp7qsk/1DG+W4Uho=; b=c2P57+7K22AL28ARpFrMRlIBXkNpEoX6l1TBqiWvFDHiADnJfhsNnBKNgxtGrwK0uy UwWMaVcPTcHVTO71Hqzmg2Nij+QLN7fRuaLfm32o1/3HZctDxNZmrojS7SuVHAdfvbK8 /gm2YAh0ePWxqmyWH+udZ9uIZkB9CkScIxNMV6ZbJtOWWJMxJhAO274jdsZCPywqC9Uq +d7qwWnZvBjC8DPQEuobhnaTaz3z7SAdsaSRdld3GdUmQ0g3RANms8qSVaXasY3TzQUa n3+N1Kcz0YWNWvY5RX/7ENblHPlJ/W7lb7v6oKClktGNIynBtE+gKj5SjT8LXRMOrFUq MqBw== X-Gm-Message-State: AG10YOTOmPcT0nyy80R0N4Yj0HML7uPOM79epDnktC9y+aiWSeYu586RK+y7SISoHRVxHw== X-Received: by 10.194.238.162 with SMTP id vl2mr22930107wjc.91.1453819698250; Tue, 26 Jan 2016 06:48:18 -0800 (PST) Received: from NewMoon.humanoids.iit.it (host240.iit.it. [90.147.26.240]) by smtp.gmail.com with ESMTPSA id ha9sm1811029wjc.3.2016.01.26.06.48.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jan 2016 06:48:17 -0800 (PST) From: Andrea Merello To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, stefan.kristiansson@saunalahti.fi Cc: linux-fbdev@vger.kernel.org, francesco.diotalevi@iit.it, claudio.lorini@iit.it, andrea.merello@gmail.com Subject: [PATCH resend] ocfb: fix tgdel and tvdel timing parameters Date: Tue, 26 Jan 2016 15:48:04 +0100 Message-Id: <1453819684-32742-1-git-send-email-andrea.merello@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to the ocfb documentation: Fix tgdel HW param should be left margin, not right. Fix tvdel HW param should upper margin, not lower. This seems to fix lock issues on certain monitors (tested on a slightly customized IP, but the FPGA guy said that it should be the same wrt this changes). Signed-off-by: Andrea Merello Acked-by: Stefan Kristiansson --- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c index c9293ae..a970edc2 100644 --- a/drivers/video/fbdev/ocfb.c +++ b/drivers/video/fbdev/ocfb.c @@ -123,11 +123,11 @@ static int ocfb_setupfb(struct ocfb_dev *fbdev) /* Horizontal timings */ ocfb_writereg(fbdev, OCFB_HTIM, (var->hsync_len - 1) << 24 | - (var->right_margin - 1) << 16 | (var->xres - 1)); + (var->left_margin - 1) << 16 | (var->xres - 1)); /* Vertical timings */ ocfb_writereg(fbdev, OCFB_VTIM, (var->vsync_len - 1) << 24 | - (var->lower_margin - 1) << 16 | (var->yres - 1)); + (var->upper_margin - 1) << 16 | (var->yres - 1)); /* Total length of frame */ hlen = var->left_margin + var->right_margin + var->hsync_len +