From patchwork Fri Feb 12 12:04:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8290391 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 95F799F3CD for ; Fri, 12 Feb 2016 12:08:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AD3C6203EB for ; Fri, 12 Feb 2016 12:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC67D203E9 for ; Fri, 12 Feb 2016 12:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbcBLMIj (ORCPT ); Fri, 12 Feb 2016 07:08:39 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55705 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbcBLMIi (ORCPT ); Fri, 12 Feb 2016 07:08:38 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue003) with ESMTPA (Nemesis) id 0MIRzP-1aRAbW2ll1-0049jg; Fri, 12 Feb 2016 13:05:29 +0100 From: Arnd Bergmann To: Andrew Jones , Konrad Rzeszutek Wilk Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Date: Fri, 12 Feb 2016 13:04:40 +0100 Message-Id: <1455278707-2008263-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:GS9pxNJWKUNuy/wX2avT8l5Qjxbaz72im+RaI1dK+fScq8J/0y8 RqK+jW6H6bPTudFCDtByCQSGqE1xx23e5+Mjwc+kLPG68ODWHu43JwhH8EFs9fxbhe9XBpY xktLUQT+afptbpa7AYA4waX2pSVpeoZQErgMDaMUUSGApPvwJyulc+4sitXrCRt5zwXauuu fh7Xf4u99vKDMetGCNacQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:e8ERRFrAeKk=:fT5KTQqeCbx8D3DIV13oR7 1OlRoQxi8zul0UkuHHzH3VbRF1UJARYL9XhnvQie1qm0kfuZJ6+UnqFFC1/DvswR8FvoPUyDO Fj8C+zOqD2RF7XiAhHlckaPh1sIFfDsgnLG62UxvaBNmFoCOuCIxIU7R5J8KVcssWdqXc9vEG 364JFRJA6r27zt0WbCK/LGvv5Lq8ePzmzCThCETEmXdsKQaa8LOj14FbyqJLmTiBLjctYQoZf 48eLwAM9C0Sso0c2+R/QJluJJj5H1AAn9LnLiHGTjC1COPVUHL731C6ZWfhLJToWs1p2ucIxI 88KpXEDZ+OnU6Qw3ivpGfGgt57wGY40jKW/maG8/xi7mKRuN5h1BI/SbBa2NMY2q/un4bOpYo od5g0CGu0Jx89zULGXO87c4eV39YGf24EHddkZKyGizhHu3uUxWkEyZwBexs0oLSMJsKOyJ9v DL4Oy3oLcvq+C51OxXl2/WcTlSlsFYpNsWLZAPUqkhc7bggBill3Vli9vGo/oXWWXN4yBeGo7 BtRD+aPmqXgt+CsOCwnqvyJ5+R0K4eEYSMhDgQ+xZ2pO+YJYV+7+Tp45/u/ZK79iDEgjZKhme 6+QY9xtRG3pAzo9VX+iNprv/EJDlgr8sgm7lR54mrXQTtiHRsl5x0P9Zer5YpnrNyLPns+auS QtBQ7sCvaFlIkfgG9UwAOeAkQrN9OC469gp0fjzqWCSBOX2oJPZuI1o47FlltBSCDYgA= Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Xen framebuffer driver selects the xen keyboard driver, so the latter will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT is a loadable module, this configuration cannot work. On mainline kernels, the symbol will be enabled but not used, while in combination with a patch I have to detect such useless configurations, we get the expected link failure: drivers/input/built-in.o: In function `xenkbd_remove': xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device' xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device' This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result in the broken select. As usual, we would be much better off without the 'select', but removing it now would likely break existing user configurations that depend on it, so this adds another hack on top to get it working. Signed-off-by: Arnd Bergmann Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND") Reviewed-by: Andrew Jones --- drivers/video/fbdev/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 8ea45a5cd806..fd3d6fd290a9 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2241,6 +2241,7 @@ config FB_VIRTUAL config XEN_FBDEV_FRONTEND tristate "Xen virtual frame buffer support" depends on FB && XEN + depends on INPUT || !INPUT_MISC select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT