diff mbox

omapfb: fix return value check in dsi_bind()

Message ID 1474127614-14350-1-git-send-email-weiyj.lk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun Sept. 17, 2016, 3:53 p.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the retrn value check which testing the wrong variable
in dsi_bind().

Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Peter Ujfalusi Sept. 20, 2016, 9:22 a.m. UTC | #1 
On 09/17/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->phy_base) {
>  		DSSERR("can't ioremap DSI PHY\n");
>  		return -ENOMEM;
>  	}
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->pll_base) {
>  		DSSERR("can't ioremap DSI PLL\n");
>  		return -ENOMEM;
>  	}
>
Tomi Valkeinen Sept. 27, 2016, 8:04 a.m. UTC | #2 
On 17/09/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().
> 
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->phy_base) {
>  		DSSERR("can't ioremap DSI PHY\n");
>  		return -ENOMEM;
>  	}
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->pll_base) {
>  		DSSERR("can't ioremap DSI PLL\n");
>  		return -ENOMEM;
>  	}
> 

Thanks, queued for 4.9.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index 9e4800a..951dd93 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -5348,7 +5348,7 @@  static int dsi_bind(struct device *dev, struct device *master, void *data)
 
 	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
 		resource_size(res));
-	if (!dsi->proto_base) {
+	if (!dsi->phy_base) {
 		DSSERR("can't ioremap DSI PHY\n");
 		return -ENOMEM;
 	}
@@ -5368,7 +5368,7 @@  static int dsi_bind(struct device *dev, struct device *master, void *data)
 
 	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
 		resource_size(res));
-	if (!dsi->proto_base) {
+	if (!dsi->pll_base) {
 		DSSERR("can't ioremap DSI PLL\n");
 		return -ENOMEM;
 	}