From patchwork Sat Sep 17 15:53:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9337285 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA7E560839 for ; Sat, 17 Sep 2016 15:53:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB82729185 for ; Sat, 17 Sep 2016 15:53:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0164291CB; Sat, 17 Sep 2016 15:53:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7723D29185 for ; Sat, 17 Sep 2016 15:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbcIQPxo (ORCPT ); Sat, 17 Sep 2016 11:53:44 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36198 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbcIQPxn (ORCPT ); Sat, 17 Sep 2016 11:53:43 -0400 Received: by mail-pa0-f66.google.com with SMTP id my20so1778187pab.3; Sat, 17 Sep 2016 08:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rAt4hUVpuiyyYEseVHc1jB2moDGmocIkuF+E590y4cU=; b=EHzBL4EOAb+abe+rfaJpWzW+oCqleiyxOb7ycQIKy/lyj/Znv5DHZRWcjT+VWfKGtH LZQBlNQPfDIIVHVeaLgGFLVQByIIEeRUgMNWcPZxWKC1Fb4ZffVr/N1WuneyiL505DIj LMngMrZ2jm0ZK6rXlvEkojCxzoyHf7XgCeQBtPUNaRvMe60W6z8jispKh6vexugdPh/Z lzp4hEPNDOdF209Aknv55ADeVS1UlCXaRP5Y7ucC7EeQfJe23vUr/ZEgnrWRnESbAM9F XT2E2tiF3oIrpr/fqBYbFYd26OF9uIOyUK6EYHePkqNQHygwEIZM2oPKQlQrMl7C6aye J3Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rAt4hUVpuiyyYEseVHc1jB2moDGmocIkuF+E590y4cU=; b=DpAS1bKG6Ma4GPkjnZKpMt59MmOd8PpDCgms8VgovBekSyJIrR3lkAUjHfGlAYQcNB //KyFZtuAF4M/rnqVwJV/uzYwfyPalF+w/XlLqGBwgx14D5pf78a0lNdIme+rl1+FaOX Rrz9DnkIaWSkow0GXmSqPj0sSf552ggZrSHM9lxUO9b63CT8x2bDGHf8Jg9vCINwUOnQ ulEBqHGhCB5hOirgYvuvBLNhT3WnN2gKz/v07NarKyqKN7NMhUAVcW7p6FhgSiwEQvaG izJO4NCoWSklYwV1Sj6+RhonU6m2aaNMS8GoSeZ+/D0fSj9KITsIjRjNbvEoXIGuhGVi 2XDA== X-Gm-Message-State: AE9vXwNpqpwC+nAcnncc1Iy0fZHj4r0hAq/eRGN8iAsgMUcONK3R+8Y84v59r43ezhG2iA== X-Received: by 10.66.253.133 with SMTP id aa5mr18555756pad.161.1474127623185; Sat, 17 Sep 2016 08:53:43 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id q8sm20001562pac.32.2016.09.17.08.53.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Sep 2016 08:53:42 -0700 (PDT) From: Wei Yongjun To: Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Dan Carpenter , Dave Airlie , Rob Clark , Peter Ujfalusi , Laurent Pinchart Cc: Wei Yongjun , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH] omapfb: fix return value check in dsi_bind() Date: Sat, 17 Sep 2016 15:53:34 +0000 Message-Id: <1474127614-14350-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix the retrn value check which testing the wrong variable in dsi_bind(). Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Wei Yongjun Reviewed-by: Peter Ujfalusi --- drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c index 9e4800a..951dd93 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data) dsi->phy_base = devm_ioremap(&dsidev->dev, res->start, resource_size(res)); - if (!dsi->proto_base) { + if (!dsi->phy_base) { DSSERR("can't ioremap DSI PHY\n"); return -ENOMEM; } @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data) dsi->pll_base = devm_ioremap(&dsidev->dev, res->start, resource_size(res)); - if (!dsi->proto_base) { + if (!dsi->pll_base) { DSSERR("can't ioremap DSI PLL\n"); return -ENOMEM; }