From patchwork Tue Nov 29 19:50:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 9453065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2DFB60710 for ; Tue, 29 Nov 2016 19:51:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E66D32831C for ; Tue, 29 Nov 2016 19:51:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D96C1283D3; Tue, 29 Nov 2016 19:51:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44AF22831C for ; Tue, 29 Nov 2016 19:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbcK2TvN (ORCPT ); Tue, 29 Nov 2016 14:51:13 -0500 Received: from botnar.kaiser.cx ([176.28.20.183]:42450 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbcK2TvM (ORCPT ); Tue, 29 Nov 2016 14:51:12 -0500 Received: from p4fd783d8.dip0.t-ipconnect.de ([79.215.131.216] helo=reykholt.kaiser.cx) by botnar.kaiser.cx with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1cBoQn-0001hN-1b; Tue, 29 Nov 2016 20:51:09 +0100 From: Martin Kaiser To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sascha Hauer , linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2] video: imxfb: remove the macros for initializing the DMACR Date: Tue, 29 Nov 2016 20:50:39 +0100 Message-Id: <1480449039-14774-1-git-send-email-martin@kaiser.cx> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <20161129074949.taj5bwnhge37pi5e@pengutronix.de> References: <20161129074949.taj5bwnhge37pi5e@pengutronix.de> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The current definitions of DMACR_HM() and DMACR_TM() are correct only for imx1, they're wrong for imx21. The macros are meant for legacy board files only, they're not applicable for boards using device tree. At the moment, there are no boards using these macros. So it should be safe to drop them rather than making them work for both imx1 and imx21, which would require a change in the platform data struct. Signed-off-by: Martin Kaiser Acked-by: Uwe Kleine-König --- Change in v2: fixed the commit message include/linux/platform_data/video-imxfb.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h index 18e9083..a5c0a71 100644 --- a/include/linux/platform_data/video-imxfb.h +++ b/include/linux/platform_data/video-imxfb.h @@ -47,10 +47,6 @@ #define LSCR1_GRAY2(x) (((x) & 0xf) << 4) #define LSCR1_GRAY1(x) (((x) & 0xf)) -#define DMACR_BURST (1 << 31) -#define DMACR_HM(x) (((x) & 0xf) << 16) -#define DMACR_TM(x) ((x) & 0xf) - struct imx_fb_videomode { struct fb_videomode mode; u32 pcr;