From patchwork Fri Mar 24 05:28:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pjambhlekar X-Patchwork-Id: 9642277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 91D64602C9 for ; Fri, 24 Mar 2017 05:28:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A4FE28464 for ; Fri, 24 Mar 2017 05:28:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6EB1228474; Fri, 24 Mar 2017 05:28:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0481E28464 for ; Fri, 24 Mar 2017 05:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089AbdCXF22 (ORCPT ); Fri, 24 Mar 2017 01:28:28 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35103 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbdCXF21 (ORCPT ); Fri, 24 Mar 2017 01:28:27 -0400 Received: by mail-pg0-f66.google.com with SMTP id g2so936023pge.2; Thu, 23 Mar 2017 22:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=H7qEDMy2awB9V79cHycMytbQBSdcyztPzj0nmNDMuQw=; b=eXbEPXw7WWA0gcknA0ZctRjy7PlSvDHeiaQK3uvJqQ+8MIG2FEe2619bRXyMDRv2ls FSYfo7cpuCjXXHPPflnozJ3ZDhzJhOZRXLUz30rR7yNC8+GepSD3PpBTEYprTYsMx5V+ UL8p+9QaNJItZXsc9nqxDGwYk4vYFKAbYWYxldvIQBy50R4f1Eu+GGX+5tyeoskADEqj ws9D+pZyQCL5gm2Q9aDw3gFF+CAagIoWc98fvC0Pn+PAF1ZTdS8QmWI+oD38OGee6tCQ 4GapZhXu9V1Qh1rss5IAzRO2WB6bh1u6YJ1qDkeo7jp+hrTcgaCrtCpDlMZmjzEbF2a8 lzZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=H7qEDMy2awB9V79cHycMytbQBSdcyztPzj0nmNDMuQw=; b=W6uMZ5WwRh6XsQOoRR2VI6a+FKrVFOvg5rb+adadNa0Zs7VUgvN4r+tmzj5a6x9GNp Q6s3sGd1r4ipMLZvv2cBDTYOEKMecBC+Fu5G7R98X4WkPD1VVn/MGQZg69WWcI5lieBT ctBbmFz7xWpx+JaEpk9TxrWCCMcNUOMGqc/jwS+L0n7Z4ZKJV2u4y1ZezsjLfAlRExtK sOSLsX6Df7C6/j2bt8355/TLiqisACd5/iWGE+kuP21xiWg7b+/sK6wUupq4Zou9mwiv /lH8XMxD5gFyp9aENhUJvZyRt0Ejsc2NxbIaJVaG+7IOpfs0sNjUcOmYouZSnTtbBio8 4U0Q== X-Gm-Message-State: AFeK/H3+Ue7cru5NJzLI7a7s3ewphusseJTNo6k/CaXhBF56c4jnFklCAnL0GUby5lcC4w== X-Received: by 10.84.177.164 with SMTP id x33mr8461286plb.75.1490333300817; Thu, 23 Mar 2017 22:28:20 -0700 (PDT) Received: from pjambhlekar-vm.nvidia.com ([202.135.238.200]) by smtp.googlemail.com with ESMTPSA id 90sm1588928pfl.24.2017.03.23.22.28.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Mar 2017 22:28:20 -0700 (PDT) From: Pushkar Jambhlekar To: Bartlomiej Zolnierkiewicz , Pushkar Jambhlekar Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers/video/fbdev: Fixing coding guidelines in acornfb.c Date: Fri, 24 Mar 2017 10:58:08 +0530 Message-Id: <1490333288-7532-1-git-send-email-pushkar.iit@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixing coding guidelines error reported by 'checkpatch.pl' Signed-off-by: Pushkar Jambhlekar --- drivers/video/fbdev/acornfb.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c index fb75b7e..0c325b4 100644 --- a/drivers/video/fbdev/acornfb.c +++ b/drivers/video/fbdev/acornfb.c @@ -101,7 +101,7 @@ extern unsigned int vram_size; /* set by setup.c */ #ifdef HAS_VIDC20 #include -#define MAX_SIZE 2*1024*1024 +#define MAX_SIZE (2*1024*1024) /* VIDC20 has a different set of rules from the VIDC: * hcr : must be multiple of 4 @@ -162,7 +162,7 @@ static void acornfb_set_timing(struct fb_info *info) if (memcmp(¤t_vidc, &vidc, sizeof(vidc))) { current_vidc = vidc; - vidc_writel(VIDC20_CTRL| vidc.control); + vidc_writel(VIDC20_CTRL | vidc.control); vidc_writel(0xd0000000 | vidc.pll_ctl); vidc_writel(0x80000000 | vidc.h_cycle); vidc_writel(0x81000000 | vidc.h_sync_width); @@ -297,7 +297,7 @@ acornfb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, pal.p = 0; vidc_writel(0x10000000); for (i = 0; i < 256; i += 1) { - pal.vidc20.red = current_par.palette[ i & 31].vidc20.red; + pal.vidc20.red = current_par.palette[i & 31].vidc20.red; pal.vidc20.green = current_par.palette[(i >> 1) & 31].vidc20.green; pal.vidc20.blue = current_par.palette[(i >> 2) & 31].vidc20.blue; vidc_writel(pal.p); @@ -1043,8 +1043,7 @@ static int acornfb_probe(struct platform_device *dev) base = dma_alloc_wc(current_par.dev, size, &handle, GFP_KERNEL); if (base == NULL) { - printk(KERN_ERR "acornfb: unable to allocate screen " - "memory\n"); + printk(KERN_ERR "acornfb: unable to allocate screen memory\n"); return -ENOMEM; } @@ -1103,8 +1102,7 @@ static int acornfb_probe(struct platform_device *dev) v_sync = h_sync / (fb_info.var.yres + fb_info.var.upper_margin + fb_info.var.lower_margin + fb_info.var.vsync_len); - printk(KERN_INFO "Acornfb: %dkB %cRAM, %s, using %dx%d, " - "%d.%03dkHz, %dHz\n", + printk(KERN_INFO "Acornfb: %dkB %cRAM, %s, using %dx%d, %d.%03dkHz, %dHz\n", fb_info.fix.smem_len / 1024, current_par.using_vram ? 'V' : 'D', VIDC_NAME, fb_info.var.xres, fb_info.var.yres,