| Message ID | 1490987402-9301-2-git-send-email-prasant.jalan@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote: > checkpatch gives WARNING: Avoid line continuations in quoted strings. > > Trivial fix by removing line continuations and adding another quote at > the start of next line. > > Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com> > --- > drivers/staging/sm750fb/sm750.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 445c68d..386d4ad 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -837,15 +837,15 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) > > /* some member of info->var had been set by fb_find_mode */ > > - pr_info("Member of info->var is :\n\ > - xres=%d\n\ > - yres=%d\n\ > - xres_virtual=%d\n\ > - yres_virtual=%d\n\ > - xoffset=%d\n\ > - yoffset=%d\n\ > - bits_per_pixel=%d\n \ > - ...\n", > + pr_info("Member of info->var is :\n" > + "xres=%d\n" > + "yres=%d\n" > + "xres_virtual=%d\n" > + "yres_virtual=%d\n" > + "xoffset=%d\n" > + "yoffset=%d\n" > + "bits_per_pixel=%d\n" > + " ...\n", > var->xres, > var->yres, > var->xres_virtual, > -- > 2.7.4 > Hi All, A gentle reminder for my patches. Any comments or updates will be helpful! Regards, Prasant -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 03, 2017 at 10:03:34PM +0530, Prasant Jalan wrote: > On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote: <snip> > A gentle reminder for my patches. > Any comments or updates will be helpful! 2 days, over a weekend, for a coding style change is pretty fast, don't you agree? I will get to these eventually, usually every other week I flush them all out. Please be patient, don't worry, the patch is not lost. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 445c68d..386d4ad 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -837,15 +837,15 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) /* some member of info->var had been set by fb_find_mode */ - pr_info("Member of info->var is :\n\ - xres=%d\n\ - yres=%d\n\ - xres_virtual=%d\n\ - yres_virtual=%d\n\ - xoffset=%d\n\ - yoffset=%d\n\ - bits_per_pixel=%d\n \ - ...\n", + pr_info("Member of info->var is :\n" + "xres=%d\n" + "yres=%d\n" + "xres_virtual=%d\n" + "yres_virtual=%d\n" + "xoffset=%d\n" + "yoffset=%d\n" + "bits_per_pixel=%d\n" + " ...\n", var->xres, var->yres, var->xres_virtual,
checkpatch gives WARNING: Avoid line continuations in quoted strings. Trivial fix by removing line continuations and adding another quote at the start of next line. Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com> --- drivers/staging/sm750fb/sm750.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)