From patchwork Sun Jun 25 19:10:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AbdAllah-MEZITI X-Patchwork-Id: 9808305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8DD00603F3 for ; Sun, 25 Jun 2017 19:11:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C69E274A3 for ; Sun, 25 Jun 2017 19:11:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 492FB2861B; Sun, 25 Jun 2017 19:11:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA8DC274A3 for ; Sun, 25 Jun 2017 19:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbdFYTLC (ORCPT ); Sun, 25 Jun 2017 15:11:02 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36197 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdFYTLB (ORCPT ); Sun, 25 Jun 2017 15:11:01 -0400 Received: by mail-wr0-f196.google.com with SMTP id 77so25878668wrb.3; Sun, 25 Jun 2017 12:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zp+C9Kk2U7cCZ2xs4rzDrv1hnfa6Y9tkEP+S+CG8pbs=; b=BdqNpLXM/xicbNQomawscqb3XLGIFs4H0sdL80vMvcYlZAaCnQEW68Cn3Am9b8kCZs 4t6XABkLDPXzRL/2/ZcIfIomp4+yK70HnypoJQo1/yz75gl4Zg0jEXPrQScaQ6dTTKs/ idNInjm8ZUHmzLPRhZJG9inTAOevkbAsBNWqyym8wcP4Yd0H/8i9NJajE8eP840Pgw+n Vi77ODpAWV/9NLBVOEmgkctnwZ7J4/Z7KWhqXzS2HgOLmFKSj6vxe79G+SBH+HIuLlMQ DU32AytFJSjjyjZT2SMSyIQEe7GKT4dzQwpwTIgvaKeu6hjLbh+kP7CuvtXJGUG7q2Kw j6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zp+C9Kk2U7cCZ2xs4rzDrv1hnfa6Y9tkEP+S+CG8pbs=; b=MjKR3RNBy1pJWbDlxuibiFv/+PUWTkq/qX9UmHrI5MQJ6ruIZQa2erojq60cujYIe9 qWfq0Le0vsfqZSpmmFYBBM2PfGMmFOZlB+mrVMB+THOWNxWLC9py8ue4FeYAl30K7Dnj +nXLhdgLnJwby3blBzFm7XpFpqB+rsbXvwCuF06s+ssHM1UZT1zzkIXall6Q3oBXiF0M k91rb/xhqDJvoSQxxFgEsuXrMAuNMYAgzru1lMpJ5b0XIGZHBqR1etyh0Ie6VP+GlpAr 1imxGa9hBwKenXdH4Cp9jTiqHOEkpmch3jOyGvjVM38FxU3eb693bVbTZsr0O1nEUETK VKRA== X-Gm-Message-State: AKS2vOzguAYHinkA6JWB+K0/e9K0VmMkHdIIqFbVomZ5v89x0QnHYzaT GepEaqGmwilr+zet X-Received: by 10.28.50.200 with SMTP id y191mr6311571wmy.104.1498417859834; Sun, 25 Jun 2017 12:10:59 -0700 (PDT) Received: from localhost.localdomain (bty91-h01-176-179-209-84.dsl.sta.abo.bbox.fr. [176.179.209.84]) by smtp.gmail.com with ESMTPSA id 201sm15537764wmy.15.2017.06.25.12.10.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Jun 2017 12:10:59 -0700 (PDT) From: AbdAllah-MEZITI To: sudipm.mukherjee@gmail.com Cc: Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: sm750fb: fix sparce warning. Date: Sun, 25 Jun 2017 21:10:36 +0200 Message-Id: <1498417843-12060-1-git-send-email-abdallah.meziti.pro@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the following sparce warnings: different lock contexts for basic block. drivers/staging/sm750fb//sm750.c:159:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block drivers/staging/sm750fb//sm750.c:231:9: warning: context imbalance in 'lynxfb_ops_copyarea' - different lock contexts for basic block drivers/staging/sm750fb//sm750.c:235:13: warning: context imbalance in 'lynxfb_ops_imageblit' - different lock contexts for basic block Signed-off-by: AbdAllah-MEZITI --- drivers/staging/sm750fb/sm750.c | 69 ++++++++++++++++++++++++++++------------- 1 file changed, 47 insertions(+), 22 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 664c220..5494a29 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -186,16 +186,24 @@ static void lynxfb_ops_fillrect(struct fb_info *info, * If not use spin_lock,system will die if user load driver * and immediately unload driver frequently (dual) */ - if (sm750_dev->fb_count > 1) + if (sm750_dev->fb_count > 1) { spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_fillrect(&sm750_dev->accel, - base, pitch, Bpp, - region->dx, region->dy, - region->width, region->height, - color, rop); - if (sm750_dev->fb_count > 1) + sm750_dev->accel.de_fillrect(&sm750_dev->accel, + base, pitch, Bpp, + region->dx, region->dy, + region->width, region->height, + color, rop); + spin_unlock(&sm750_dev->slock); + } else { + sm750_dev->accel.de_fillrect(&sm750_dev->accel, + base, pitch, Bpp, + region->dx, region->dy, + region->width, region->height, + color, rop); + } + } static void lynxfb_ops_copyarea(struct fb_info *info, @@ -220,16 +228,24 @@ static void lynxfb_ops_copyarea(struct fb_info *info, * If not use spin_lock, system will die if user load driver * and immediately unload driver frequently (dual) */ - if (sm750_dev->fb_count > 1) + if (sm750_dev->fb_count > 1) { spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_copyarea(&sm750_dev->accel, - base, pitch, region->sx, region->sy, - base, pitch, Bpp, region->dx, region->dy, - region->width, region->height, - HW_ROP2_COPY); - if (sm750_dev->fb_count > 1) + sm750_dev->accel.de_copyarea(&sm750_dev->accel, + base, pitch, region->sx, region->sy, + base, pitch, Bpp, region->dx, region->dy, + region->width, region->height, + HW_ROP2_COPY); + spin_unlock(&sm750_dev->slock); + } else { + sm750_dev->accel.de_copyarea(&sm750_dev->accel, + base, pitch, region->sx, region->sy, + base, pitch, Bpp, region->dx, region->dy, + region->width, region->height, + HW_ROP2_COPY); + } + } static void lynxfb_ops_imageblit(struct fb_info *info, @@ -269,17 +285,26 @@ static void lynxfb_ops_imageblit(struct fb_info *info, * If not use spin_lock, system will die if user load driver * and immediately unload driver frequently (dual) */ - if (sm750_dev->fb_count > 1) + if (sm750_dev->fb_count > 1) { spin_lock(&sm750_dev->slock); - sm750_dev->accel.de_imageblit(&sm750_dev->accel, - image->data, image->width >> 3, 0, - base, pitch, Bpp, - image->dx, image->dy, - image->width, image->height, - fgcol, bgcol, HW_ROP2_COPY); - if (sm750_dev->fb_count > 1) + sm750_dev->accel.de_imageblit(&sm750_dev->accel, + image->data, image->width >> 3, 0, + base, pitch, Bpp, + image->dx, image->dy, + image->width, image->height, + fgcol, bgcol, HW_ROP2_COPY); + spin_unlock(&sm750_dev->slock); + } else { + sm750_dev->accel.de_imageblit(&sm750_dev->accel, + image->data, image->width >> 3, 0, + base, pitch, Bpp, + image->dx, image->dy, + image->width, image->height, + fgcol, bgcol, HW_ROP2_COPY); + } + } static int lynxfb_ops_pan_display(struct fb_var_screeninfo *var,