From patchwork Thu Jul 20 17:39:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9855487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 15FBB600F5 for ; Thu, 20 Jul 2017 17:45:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0582128828 for ; Thu, 20 Jul 2017 17:45:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE6D62882B; Thu, 20 Jul 2017 17:45:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A996728828 for ; Thu, 20 Jul 2017 17:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965983AbdGTRko (ORCPT ); Thu, 20 Jul 2017 13:40:44 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38264 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965907AbdGTRkm (ORCPT ); Thu, 20 Jul 2017 13:40:42 -0400 Received: by mail-pf0-f195.google.com with SMTP id c23so2910016pfe.5; Thu, 20 Jul 2017 10:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/SH8oFRLeK4LDEUn/BVPXxxfC1X0007cr1UNctnRQJQ=; b=NOxa4NAyaAOaQ63uS3jd6YolG15rcWOv40ZNb2uyWqbxVW7pKZKHKGDcTocTQZSY0Q gfv1jbhDZraI1J2H/8nrsVpzwZqizFU+besmNteN9ZTHxHd8tR9ppY9lhD5YHs5G+Aiu bgbkxwLrbNZefx7dCBvxOVTogFvU30VKseT74Bk9O1G2PaqMNtc76hpY8nDdl2T4cgNl 9TrSTTmDAtG6nZOIYs9kgmTsrJ8RuRmzvXjKPBWd9i3t9M93RNy5FpCHnmkD50PYq18/ 6OC1BbeKpMq/QGd0p4xwpuTy7r7YFTfxnBn3RAdo7RN/Bb+Yl+gdWK9pIRIx4S/cnD3y JvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/SH8oFRLeK4LDEUn/BVPXxxfC1X0007cr1UNctnRQJQ=; b=VFwYfMXgC43msaEnsCAKk1QF+pxjE4XE26W3PiWGiFfwGePsI4Z1TysBktVJYk28R6 CxX7AVeuetyDbat2ZXAI6ENp135Kt31y1Hz+vvAVfn/u1pLqrZUpq7p3S9jY31jdX0vN S4k1DMVndLBFuaSDPE/CIbG+Uc2FVbIaGPIyvCBySqTknuMjAIVyt65KMNs52i1qftvt aIFSguL3VAn4I/ZiMaz4omDF8g2sOYE3ekpNFDldCgNYVcFtuSxMu+BgbG9K+25ENDzl Lz1mG4fmiXST2pJlW+sYdx19p6ilabldCx5hEN/wz0f4/QY3EnJW2O9AEMTScC9VjUTI 5TOA== X-Gm-Message-State: AIVw110pMSVRqnKLcH79nC6b+BmBt78RnOiamvv2AEql0TNHj6fOJG94 ujPn1Fmi9QKTCQ== X-Received: by 10.99.165.71 with SMTP id r7mr4604253pgu.65.1500572441781; Thu, 20 Jul 2017 10:40:41 -0700 (PDT) Received: from localhost.localdomain ([103.16.70.17]) by smtp.gmail.com with ESMTPSA id n90sm6315528pfk.105.2017.07.20.10.40.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 10:40:41 -0700 (PDT) From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/28] video: fbdev: savage: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:36 +0530 Message-Id: <1500572393-18844-12-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 19916 1240 8 21164 52ac fbdev/savage/savagefb_driver.o File size After adding 'const': text data bss dec hex filename 20684 472 8 21164 52ac fbdev/savage/savagefb_driver.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/savage/savagefb_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c index c30a91c..c204683 100644 --- a/drivers/video/fbdev/savage/savagefb_driver.c +++ b/drivers/video/fbdev/savage/savagefb_driver.c @@ -2429,7 +2429,7 @@ static int savagefb_resume(struct pci_dev* dev) } -static struct pci_device_id savagefb_devices[] = { +static const struct pci_device_id savagefb_devices[] = { {PCI_VENDOR_ID_S3, PCI_CHIP_SUPSAV_MX128, PCI_ANY_ID, PCI_ANY_ID, 0, 0, FB_ACCEL_SUPERSAVAGE},