From patchwork Thu Jul 20 17:39:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9855463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4137600F5 for ; Thu, 20 Jul 2017 17:43:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 921CE28715 for ; Thu, 20 Jul 2017 17:43:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 872C028818; Thu, 20 Jul 2017 17:43:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44A5628715 for ; Thu, 20 Jul 2017 17:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966064AbdGTRlI (ORCPT ); Thu, 20 Jul 2017 13:41:08 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35236 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966030AbdGTRlG (ORCPT ); Thu, 20 Jul 2017 13:41:06 -0400 Received: by mail-pg0-f67.google.com with SMTP id d193so3308860pgc.2; Thu, 20 Jul 2017 10:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gEwukZ0ExPUBm7ZqghV5wbOiO/DmD4d5i7DUZOpP4h0=; b=Y8Ol58OGsKuY+LXuCY8GEVNgCg0UqclArbtUUKptu6ta1LKsp2BYurS+CrebMxst2j k82wzM6a+85VT08yaUIoa3SquDoT48FzZhIeN0XqZvVb1hdAPo9ekYtF/QEk54MX+HYp 4DdbUdXJFw4wb1ynH4wV8kFarPw/EzLN+MKQUviKN4wl5I9tWvPuoe1gFHso8QseUbyQ atrLTBWaWpAZ+nxxlm8ISqAlDqfbyEMQgTOvUEL0llMiyOc8PizdzbRZhz+Dk1W2nK/V U0crFjYIw34kL9/fx6vHUkB43ck/T1NehcYbGCoyTyBkg9/TrRePfjWqgCB8wVn121IM cl2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gEwukZ0ExPUBm7ZqghV5wbOiO/DmD4d5i7DUZOpP4h0=; b=PGuwM1fdWWKQoVC/5ySFryki906IJvs2ge5aUZUY9yGVlMXP7J4XI/Xu6SgXJrZxv+ 4ROFPjISqijFJdm+YnUgCwalXJcNHhKh/6hqrKzG7xrjLjckxaLhcktNH+XpxJzECnHH HrMkc/fcVhJIrKflb1S9dV0QWj2/BhLKg92FOm/HZnOGghLJsfpd2TJledKdOKaTIKSk fw8yGdSmMtmVr1wuzfbYkMWbNwBgGIqCCMYWtaZl/e2Uj3GA0haQzbo6k5aiMTqsQie4 Bau4RoDZ4PjR+aKri+IwK7v27PrtLjKqtSEg5k8ZAnwD/8c50sqRv5IYPclyWXe4eHdS 3ZPw== X-Gm-Message-State: AIVw113cRB9A1PBwdsDxzHgv72SQ1HEnKJk5QhqG/q2MCKQTTTioJq/W YYxy3OOH/5y5ow== X-Received: by 10.98.65.76 with SMTP id o73mr4682591pfa.88.1500572466200; Thu, 20 Jul 2017 10:41:06 -0700 (PDT) Received: from localhost.localdomain ([103.16.70.17]) by smtp.gmail.com with ESMTPSA id n90sm6315528pfk.105.2017.07.20.10.41.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 10:41:05 -0700 (PDT) From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/28] video: fbdev: tdfx: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:44 +0530 Message-Id: <1500572393-18844-20-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 8432 1456 16 9904 26b0 drivers/video/fbdev/tdfxfb.o File size After adding 'const': text data bss dec hex filename 8560 1328 16 9904 26b0 drivers/video/fbdev/tdfxfb.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/tdfxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index d5fa313..dec1fed 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -120,7 +120,7 @@ static const struct fb_var_screeninfo tdfx_var = { static int tdfxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id); static void tdfxfb_remove(struct pci_dev *pdev); -static struct pci_device_id tdfxfb_id_table[] = { +static const struct pci_device_id tdfxfb_id_table[] = { { PCI_VENDOR_ID_3DFX, PCI_DEVICE_ID_3DFX_BANSHEE, PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16, 0xff0000, 0 },