From patchwork Thu Jul 20 17:39:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9855449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 553A7600F5 for ; Thu, 20 Jul 2017 17:42:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4287628715 for ; Thu, 20 Jul 2017 17:42:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3725E28818; Thu, 20 Jul 2017 17:42:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFB5E28715 for ; Thu, 20 Jul 2017 17:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964960AbdGTRmX (ORCPT ); Thu, 20 Jul 2017 13:42:23 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36164 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966030AbdGTRlY (ORCPT ); Thu, 20 Jul 2017 13:41:24 -0400 Received: by mail-pf0-f195.google.com with SMTP id a11so2916604pfj.3; Thu, 20 Jul 2017 10:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J0RqqFkbboGVol8GVwHfbVMEVVo3Yyn4OekEyNWlzsE=; b=cFnewpmcF7yGkiBmw2C6Zb9GEtkSLT8wg2MdkPlAhQEn7vBzjeX98lmT0Vmsp60zoO rQNELiyMm4sbFXna22TZbRMkfiLdtWciQ+MGRI2YPbO7M4mqHKgTlmZPRI3bnA3YD6va 43cwWWD+qsYFLnh1KrfB46E6+JyhPZd9TwnE9/9nYWbG8V3g4tiYa3w4EnNBM0beFxjq cs7x8J1vU64CcbH/4rmTYhx4btEgFEdB1of7rMNlfN/aFowkQA/ooUpSyG5p7zQt593P uek5r+Z8hgk68faHKR31eF6DelM8xCXcGww56WC5b5JU9EoWuXmMAYFnkbaHOmZzqnck lREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J0RqqFkbboGVol8GVwHfbVMEVVo3Yyn4OekEyNWlzsE=; b=qY31WtpP/plBvI9xinOXQv65vKdSdq5n+79HDkeDQ1drS4ZZ4AKvdona22Sapb16xB XOTZ3aDGtTWNr6G6uo4n6BTYFVZAFHqIyJA+q9Bkv53Pd1jiXbb3KRiubyr96/zfLoRx WQVXAogVPi0haJBLSJYrLWvu6eI8iVK+/yPn2IJmRN9fzMrY9xEcztDmtfYd9YjROp+l JKZ1sIqn69l5s1RISVlr8qdSjVxgF+4Zaxb0QB8rqT15cC9pSSCdQBnAXluB0wc9wBv3 iwI2h7IN7xiuhFROEiD9nWZDEyYmW9XEqyR5oAQjMPssG1wE2rC12wltcnsV5IIEB84Q cBOg== X-Gm-Message-State: AIVw111ruvU+jte2eN/Ek2eCTwqRg0XTMjn9MG7wEgg+LnrqR/qU13w/ eTt1bz6OnN5qbw== X-Received: by 10.98.64.129 with SMTP id f1mr4595204pfd.225.1500572484397; Thu, 20 Jul 2017 10:41:24 -0700 (PDT) Received: from localhost.localdomain ([103.16.70.17]) by smtp.gmail.com with ESMTPSA id n90sm6315528pfk.105.2017.07.20.10.41.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 10:41:23 -0700 (PDT) From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/28] video: fbdev: s3fb: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:50 +0530 Message-Id: <1500572393-18844-26-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 20994 2440 8 23442 5b92 drivers/video/fbdev/s3fb.o File size After adding 'const': text data bss dec hex filename 21506 1928 8 23442 5b92 drivers/video/fbdev/s3fb.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/s3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 13b1090..d63f23e 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -1483,7 +1483,7 @@ static int s3_pci_resume(struct pci_dev* dev) /* List of boards that we are trying to support */ -static struct pci_device_id s3_devices[] = { +static const struct pci_device_id s3_devices[] = { {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8810), .driver_data = CHIP_XXX_TRIO}, {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8811), .driver_data = CHIP_XXX_TRIO}, {PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8812), .driver_data = CHIP_M65_AURORA64VP},