From patchwork Thu Jul 20 17:39:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9855501 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BEDF8600F5 for ; Thu, 20 Jul 2017 17:46:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE6EC2882A for ; Thu, 20 Jul 2017 17:46:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A34342882C; Thu, 20 Jul 2017 17:46:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DFBB2882A for ; Thu, 20 Jul 2017 17:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935855AbdGTRq1 (ORCPT ); Thu, 20 Jul 2017 13:46:27 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:32862 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965949AbdGTRkc (ORCPT ); Thu, 20 Jul 2017 13:40:32 -0400 Received: by mail-pf0-f193.google.com with SMTP id e199so2914952pfh.0; Thu, 20 Jul 2017 10:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4SFR3ftrX3RV8tBnxNOUgXtoRS94IhMAfDcBnIHRFuM=; b=bVHHDyx2bTz5CGOxymPbhobBdqnZFnWnkByMWdpbaUpEE2tgWYqbusDLwjI8o/0nMv wEhRVZLgIpjDKDwPDc/aIKOJvBCJHzTV7cDkQkEFdVeZl4MbFK/ZfFig6xRD9deP7tfr x3LvHDjlYr34bYaCvmPHQBkOK3oCXMKrSZkQZD+32ei8vRLtpKlhDqSbG4Sd/gzABLBw wCAOw3btI8rQ0s2KCC7duqZoLkqgCR3hXtAQgntpmKmQbUg1VX4CEIAhgEcm3Tq9kq7m F+rTUmX8vCUgwHtuPjtieXrMzMUC8A5CAtEmgYgaHw9wxfu0Odzb5MxozRIPTxq6ozW5 24pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4SFR3ftrX3RV8tBnxNOUgXtoRS94IhMAfDcBnIHRFuM=; b=cLcB2D4gFXPCp5+XZ3842D+MnPTx7fXV/MWtg2dx1NQ0NlqJx+Ppk3soPhGYryf9w4 QRNQF8ezLieHqWfhhJA3oaykVlKw0EoLXMfpcTkV4dFI2Fh9atksUC8efjA+uK1onrJg ei+1NvqDXtaVDr/4eZ7560ffEZgQh5AjTuGn21xL2S/jsVRxAncJNIt7cBfnHYF3jkBS I/jTYES5GtrsjRWlPkMFX9LXWDdIRVdny/mz5nnDM27lT2f3wjzjCcH6DCm+i79CzAQR G2fFppcoVDFVqSZPaO2iHHzOEFJ/F4i7EYFLrgUhGbHXilcL+LR5GmPAk5Aju3tReAQA hVvQ== X-Gm-Message-State: AIVw113FDsf6RAmZLLWvWFdRro2kC8PO9/G/5DOgjaeJJ05S3hs/A5Rh rwMNNCzr/7zhEA== X-Received: by 10.84.210.236 with SMTP id a99mr5039276pli.297.1500572431866; Thu, 20 Jul 2017 10:40:31 -0700 (PDT) Received: from localhost.localdomain ([103.16.70.17]) by smtp.gmail.com with ESMTPSA id n90sm6315528pfk.105.2017.07.20.10.40.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 10:40:30 -0700 (PDT) From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/28] video: fbdev: tridentfb: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:33 +0530 Message-Id: <1500572393-18844-9-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 13206 1232 40 14478 388e video/fbdev/tridentfb.o File size After adding 'const': text data bss dec hex filename 13910 528 40 14478 388e video/fbdev/tridentfb.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/tridentfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 8a5bbc1..2847061 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -1737,7 +1737,7 @@ static void trident_pci_remove(struct pci_dev *dev) } /* List of boards that we are trying to support */ -static struct pci_device_id trident_devices[] = { +static const struct pci_device_id trident_devices[] = { {PCI_VENDOR_ID_TRIDENT, BLADE3D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, {PCI_VENDOR_ID_TRIDENT, CYBERBLADEi7, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, {PCI_VENDOR_ID_TRIDENT, CYBERBLADEi7D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},