From patchwork Thu Sep 14 12:32:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhumika Goyal X-Patchwork-Id: 9952963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E89CB60230 for ; Thu, 14 Sep 2017 12:32:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 197802903B for ; Thu, 14 Sep 2017 12:32:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D58C29054; Thu, 14 Sep 2017 12:32:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 928EE2903B for ; Thu, 14 Sep 2017 12:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdINMc3 (ORCPT ); Thu, 14 Sep 2017 08:32:29 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33009 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbdINMc0 (ORCPT ); Thu, 14 Sep 2017 08:32:26 -0400 Received: by mail-pg0-f65.google.com with SMTP id i130so1634325pgc.0; Thu, 14 Sep 2017 05:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FTHJI/HGOrFctUIJca8LnqNdeA4WnxuhQdoaYExHJwk=; b=F4DMFNjDOpguCfLrp+0sSBd9D5A5p28UOKGG23ldvVfzI1hCpz600ccO2As01tCmTu gXl2HoPE4yC+riA9ACqIXt6Z5E4olpSKW47plYz6dHqwznwdimCbm/H6i/20e8iXr0dw ufKisvnCCy+jRfAjR0ewNm2DqU2OTu23e3vcVACIBOVowIxctQNk3nZmy9RkwtGB+YXg TqJkQLcG6bXqWjjYqIG5DqVsMuTH9A6mIVSG8a8BJ4lVKNZoi8eo6vtRq3oSDGt4ca+6 f8czbozKmsQbTf646yNe7s7+V/4yIE3aoMCy+rVQuEbRMdGbORa8tok95rQIHjPxcdlP /5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FTHJI/HGOrFctUIJca8LnqNdeA4WnxuhQdoaYExHJwk=; b=sjyhKZ9daEtHJVsdYKfjU0TZIHUkkx27Toplkp8whJCmiEClALR0Jm0SulrILxlTLm rJL3OEXvbkJ045lgyHAJfpl8IejQGAqgXh/CPWNKkA724BOXee3UnYkiIhJnVyW+Jrmo b1sAC9uNJPO9l7VqRSy1C4fCHd+KOS3V1LBuGcmyt+nAkdrlqKoZMPzJnMaDo1IWVL61 8PZh2kPw1ksiz37MJgklNp+ZAX9cJSLJmYJWv91GTgSMnNUP8R5oaK1v5HOyCcEZCNfx rEQ4MXwVdoLhf8FI2Pv46X0jGeQ20abuM2suP0QekqcUh26HV1UxQaQCAI2axcREqPaN KnXg== X-Gm-Message-State: AHPjjUjnaSyGTzWnMoY5M4V9d+CVCL9y6BY9HI08XCLFjyChsMQAR1fk gcv1DS61cFN9pA== X-Google-Smtp-Source: AOwi7QAgeKlMm3UK/+FAahYrAYwlWgDqmFOOt5+XItnUEqNEoa27BalwLh+OyV3ntfMaApBuN2d1RA== X-Received: by 10.159.244.5 with SMTP id x5mr3454632plr.316.1505392346026; Thu, 14 Sep 2017 05:32:26 -0700 (PDT) Received: from gmail.com ([117.196.107.130]) by smtp.gmail.com with ESMTPSA id y74sm31358530pfa.164.2017.09.14.05.32.21 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Sep 2017 05:32:24 -0700 (PDT) Received: by gmail.com (sSMTP sendmail emulation); Thu, 14 Sep 2017 18:02:17 +0530 From: Bhumika Goyal To: julia.lawall@lip6.fr, b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bhumika Goyal Subject: [PATCH] video: fbdev: make fb_var_screeninfo static, const and __initconst Date: Thu, 14 Sep 2017 18:02:14 +0530 Message-Id: <1505392334-8001-1-git-send-email-bhumirks@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make these structures static as they are not referenced in any other file. Make them const as they are used only during a copy operation. Replace __initdata with __initconst in file igafb.c to avoid section conflict error. Signed-off-by: Bhumika Goyal --- The changes are not compile tested as I could not find the right architecture to cross compile the files. drivers/video/fbdev/dnfb.c | 2 +- drivers/video/fbdev/igafb.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/dnfb.c b/drivers/video/fbdev/dnfb.c index 7b1492d..0941500 100644 --- a/drivers/video/fbdev/dnfb.c +++ b/drivers/video/fbdev/dnfb.c @@ -115,7 +115,7 @@ .fb_imageblit = cfb_imageblit, }; -struct fb_var_screeninfo dnfb_var = { +static const struct fb_var_screeninfo dnfb_var = { .xres = 1280, .yres = 1024, .xres_virtual = 2048, diff --git a/drivers/video/fbdev/igafb.c b/drivers/video/fbdev/igafb.c index 486f188..607b6c0 100644 --- a/drivers/video/fbdev/igafb.c +++ b/drivers/video/fbdev/igafb.c @@ -97,7 +97,7 @@ struct fb_var_screeninfo default_var = { }; #ifdef CONFIG_SPARC -struct fb_var_screeninfo default_var_1024x768 __initdata = { +static const struct fb_var_screeninfo default_var_1024x768 __initconst = { /* 1024x768, 75 Hz, Non-Interlaced (78.75 MHz dotclock) */ .xres = 1024, .yres = 768, @@ -120,7 +120,7 @@ struct fb_var_screeninfo default_var_1024x768 __initdata = { .vmode = FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED }; -struct fb_var_screeninfo default_var_1152x900 __initdata = { +static const struct fb_var_screeninfo default_var_1152x900 __initconst = { /* 1152x900, 76 Hz, Non-Interlaced (110.0 MHz dotclock) */ .xres = 1152, .yres = 900, @@ -143,7 +143,7 @@ struct fb_var_screeninfo default_var_1152x900 __initdata = { .vmode = FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED }; -struct fb_var_screeninfo default_var_1280x1024 __initdata = { +static const struct fb_var_screeninfo default_var_1280x1024 __initconst = { /* 1280x1024, 75 Hz, Non-Interlaced (135.00 MHz dotclock) */ .xres = 1280, .yres = 1024,