From patchwork Tue Feb 27 00:04:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 10243979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1534060386 for ; Tue, 27 Feb 2018 00:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05F722A405 for ; Tue, 27 Feb 2018 00:05:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDC442A4A1; Tue, 27 Feb 2018 00:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 811A22A405 for ; Tue, 27 Feb 2018 00:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbeB0AEb (ORCPT ); Mon, 26 Feb 2018 19:04:31 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:40726 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbeB0AE3 (ORCPT ); Mon, 26 Feb 2018 19:04:29 -0500 Received: by mail-pg0-f68.google.com with SMTP id g2so6826987pgn.7 for ; Mon, 26 Feb 2018 16:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YkbTZUnKK79uTL4ubxkilDrq9E2x+xrlbCGIag8e3uc=; b=dilLDk/1igqzx8GwW0gnQv2k7GJjMTZyHDb1JWMDW6p784FQJwt1YPMVAIssFlDsfi zklQ9mOnQGx4dspU2+s+i0dgm75+Frz3tYvowyeH8ouqbFNijDYu55pAGqrEgf7N9WJp NE3vfreSBMmzVy45sAbReGO33i+MuThcUMqqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YkbTZUnKK79uTL4ubxkilDrq9E2x+xrlbCGIag8e3uc=; b=gNDM8OO9xz3Cc0Y6eoTebJPIYUF3fyFPn2eZX2LvpIHxtZAsqUKOLjXIkwmcaKP+Ew 4vivD0b1DFOz1yV97HNhgeNc6ZAjDtMoLz+oNKiDUQBlE5xNY0w/59mJZa3vJjVoptUf KOyJmGsjH/mlOZsV2YeQLmh2DxyOHBXewE6y4r/iO6M1KsIy/Dor2NMmZyBe4o8xLYjA Rap+z9jKdbB5ozt3mN2VzOpv16G464GrG75WepkAxAewIhDDvz1BDjCl2+P1VDNOy2n6 M56lPezO1hBH8K6dTQBNc8Q3MDOkjkbYmhF6shqDBXnIKJgTYSVlsnUyzAH3AJw6cBg2 jgPw== X-Gm-Message-State: APf1xPAsDHpeb0w3RcSyAVIToQJ+lDnG8V455Gg20rq6v9Ru5Ae6oSvi Ibrz5OpxpJsmzoTjQswu17Pljw== X-Google-Smtp-Source: AH8x225DZnPH69ivn88Z8Ty50ojAgav9QLgiG8dhNxhQ5R3D8Q90QMy7+8hpm/0xFfrq1YNXDAs8sg== X-Received: by 10.101.96.73 with SMTP id b9mr9256413pgv.339.1519689869383; Mon, 26 Feb 2018 16:04:29 -0800 (PST) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id c18sm22276234pfd.100.2018.02.26.16.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2018 16:04:27 -0800 (PST) From: Kees Cook To: Greg Kroah-Hartman Cc: Kees Cook , Thomas Winischhofer , Sami Tolvanen , Bartlomiej Zolnierkiewicz , Nicolas Pitre , linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] console: SisUSB2VGA: Drop dummy con_font_get() Date: Mon, 26 Feb 2018 16:04:18 -0800 Message-Id: <1519689860-7421-2-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519689860-7421-1-git-send-email-keescook@chromium.org> References: <1519689860-7421-1-git-send-email-keescook@chromium.org> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As done in commit: 724ba8b30b04 ("console/dummy: leave .con_font_get set to NULL") This drops the dummy .con_font_get(), as it could leave arguments uninitialized. Cc: Thomas Winischhofer Signed-off-by: Kees Cook --- drivers/usb/misc/sisusbvga/sisusb_con.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c b/drivers/usb/misc/sisusbvga/sisusb_con.c index 73f7bde78e11..998df891bdde 100644 --- a/drivers/usb/misc/sisusbvga/sisusb_con.c +++ b/drivers/usb/misc/sisusbvga/sisusb_con.c @@ -1358,7 +1358,6 @@ static const struct consw sisusb_dummy_con = { .con_switch = SISUSBCONDUMMY, .con_blank = SISUSBCONDUMMY, .con_font_set = SISUSBCONDUMMY, - .con_font_get = SISUSBCONDUMMY, .con_font_default = SISUSBCONDUMMY, .con_font_copy = SISUSBCONDUMMY, };