From patchwork Thu Sep 6 07:23:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 1412371 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 28AB240220 for ; Thu, 6 Sep 2012 07:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754426Ab2IFHXW (ORCPT ); Thu, 6 Sep 2012 03:23:22 -0400 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:33604 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223Ab2IFHXU (ORCPT ); Thu, 6 Sep 2012 03:23:20 -0400 Received: from jdelvare.pck.nerim.net ([62.212.121.182] helo=endymion.delvare) by services.gcu-squad.org (GCU Mailer Daemon) with esmtpsa id 1T9WQn-0006Ai-9L (TLSv1:AES128-SHA:128) (envelope-from ) ; Thu, 06 Sep 2012 09:23:17 +0200 Date: Thu, 6 Sep 2012 09:23:11 +0200 From: Jean Delvare To: linux-fbdev@vger.kernel.org Cc: Florian Tobias Schandinat Subject: [PATCH] video: bf*: Add missing spinlock init Message-ID: <20120906092311.22961acd@endymion.delvare> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org It doesn't seem these spinlocks were properly initialized. Signed-off-by: Jean Delvare Cc: Florian Tobias Schandinat --- I can't even build-test this. drivers/video/bf54x-lq043fb.c | 1 + drivers/video/bfin-lq035q1-fb.c | 1 + drivers/video/bfin-t350mcqb-fb.c | 1 + 3 files changed, 3 insertions(+) --- linux-3.6-rc4.orig/drivers/video/bf54x-lq043fb.c 2012-07-21 22:58:29.000000000 +0200 +++ linux-3.6-rc4/drivers/video/bf54x-lq043fb.c 2012-09-06 08:49:37.812899185 +0200 @@ -525,6 +525,7 @@ static int __devinit bfin_bf54x_probe(st info = fbinfo->par; info->fb = fbinfo; info->dev = &pdev->dev; + spin_lock_init(&info->lock); platform_set_drvdata(pdev, fbinfo); --- linux-3.6-rc4.orig/drivers/video/bfin-lq035q1-fb.c 2012-07-21 22:58:29.000000000 +0200 +++ linux-3.6-rc4/drivers/video/bfin-lq035q1-fb.c 2012-09-06 08:48:50.618858480 +0200 @@ -577,6 +577,7 @@ static int __devinit bfin_lq035q1_probe( info = fbinfo->par; info->fb = fbinfo; info->dev = &pdev->dev; + spin_lock_init(&info->lock); info->disp_info = pdev->dev.platform_data; --- linux-3.6-rc4.orig/drivers/video/bfin-t350mcqb-fb.c 2012-07-21 22:58:29.000000000 +0200 +++ linux-3.6-rc4/drivers/video/bfin-t350mcqb-fb.c 2012-09-06 08:48:12.310825601 +0200 @@ -447,6 +447,7 @@ static int __devinit bfin_t350mcqb_probe info = fbinfo->par; info->fb = fbinfo; info->dev = &pdev->dev; + spin_lock_init(&info->lock); platform_set_drvdata(pdev, fbinfo);