From patchwork Wed Jan 9 19:12:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1954131 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6D1CBDF2EB for ; Wed, 9 Jan 2013 19:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340Ab3AITMJ (ORCPT ); Wed, 9 Jan 2013 14:12:09 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:58771 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932302Ab3AITMJ (ORCPT ); Wed, 9 Jan 2013 14:12:09 -0500 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3YhKhf6Rx2z4KK2B; Wed, 9 Jan 2013 20:12:02 +0100 (CET) X-Auth-Info: CJ+L6zi5wdsWjR9JGNVMEvwQUmhrR2UboSJ0vQG9Ae0= Received: from mashiro.localnet (unknown [195.140.253.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mnet-online.de (Postfix) with ESMTPSA id 3YhKhf5MBgzbbgn; Wed, 9 Jan 2013 20:12:02 +0100 (CET) From: Marek Vasut To: Steffen Trumtrar Subject: Re: [PATCHv16 0/7] of: add display helper Date: Wed, 9 Jan 2013 20:12:01 +0100 User-Agent: KMail/1.13.7 (Linux/3.6-trunk-amd64; KDE/4.8.4; x86_64; ; ) Cc: devicetree-discuss@lists.ozlabs.org, "Rob Herring" , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Laurent Pinchart" , "Thierry Reding" , "Guennady Liakhovetski" , linux-media@vger.kernel.org, "Tomi Valkeinen" , "Stephen Warren" , kernel@pengutronix.de, "Florian Tobias Schandinat" , "David Airlie" , "Rob Clark" , "Leela Krishna Amudala" References: <1355850256-16135-1-git-send-email-s.trumtrar@pengutronix.de> In-Reply-To: <1355850256-16135-1-git-send-email-s.trumtrar@pengutronix.de> MIME-Version: 1.0 Message-Id: <201301092012.01985.marex@denx.de> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Dear Steffen Trumtrar, > Hi! > > Finally, right in time before the end of the world on friday, v16 of the > display helpers. I tested this on 3.8-rc1 (next 20130103) with the imx drm driver. After adding the following piece of code (quick hack), this works just fine. Thanks! if (imxpd->edid) { @@ -72,6 +73,15 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) num_modes++; } + if (np) { + struct drm_display_mode *mode = drm_mode_create(connector->dev); + of_get_drm_display_mode(np, &imxpd->mode, 0); + drm_mode_copy(mode, &imxpd->mode); + mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, + drm_mode_probed_add(connector, mode); + num_modes++; + } + return num_modes; } Best regards, Marek Vasut --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx- drm/parallel-display.c index a8064fc..e45002a 100644 --- a/drivers/staging/imx-drm/parallel-display.c +++ b/drivers/staging/imx-drm/parallel-display.c @@ -57,6 +57,7 @@ static void imx_pd_connector_destroy(struct drm_connector *connector) static int imx_pd_connector_get_modes(struct drm_connector *connector) { struct imx_parallel_display *imxpd = con_to_imxpd(connector); + struct device_node *np = imxpd->dev->of_node; int num_modes = 0;