| Message ID | 20131216112110.GA4849@rashika (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday, December 16, 2013 8:21 PM, Rashika Kheria wrote: > > Removes unused function genericbl_limit_intensity() in > backlight/generic_bl.c. > > This eliminates the following warning in backlight/generic_bl.c: > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for > ‘genericbl_limit_intensity’ [-Wmissing-prototypes] Hi Eric, Originally, genericbl_limit_intensity() was added by you. (commit: bfdcaa3 "lcd: add corgibl_limit_intensity() to corgi_lcd") Currently, genericbl_limit_intensity() is not called anywhere in mainline kernel. Can we remove this genericbl_limit_intensity()? Best regards, Jingoo Han > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > --- > drivers/video/backlight/generic_bl.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 5d8d652..67dfb93 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd) > return genericbl_intensity; > } > > -/* > - * Called when the battery is low to limit the backlight intensity. > - * If limit==0 clear any limit, otherwise limit the intensity > - */ > -void genericbl_limit_intensity(int limit) > -{ > - struct backlight_device *bd = generic_backlight_device; > - > - mutex_lock(&bd->ops_lock); > - if (limit) > - bd->props.state |= GENERICBL_BATTLOW; > - else > - bd->props.state &= ~GENERICBL_BATTLOW; > - backlight_update_status(generic_backlight_device); > - mutex_unlock(&bd->ops_lock); > -} > -EXPORT_SYMBOL(genericbl_limit_intensity); > - > static const struct backlight_ops genericbl_ops = { > .options = BL_CORE_SUSPENDRESUME, > .get_brightness = genericbl_get_intensity, > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote: > Removes unused function genericbl_limit_intensity() in > backlight/generic_bl.c. > > This eliminates the following warning in backlight/generic_bl.c: > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for ‘genericbl_limit_intensity’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> > drivers/video/backlight/generic_bl.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 5d8d652..67dfb93 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd) > return genericbl_intensity; > } > > -/* > - * Called when the battery is low to limit the backlight intensity. > - * If limit==0 clear any limit, otherwise limit the intensity > - */ > -void genericbl_limit_intensity(int limit) > -{ > - struct backlight_device *bd = generic_backlight_device; > - > - mutex_lock(&bd->ops_lock); > - if (limit) > - bd->props.state |= GENERICBL_BATTLOW; > - else > - bd->props.state &= ~GENERICBL_BATTLOW; > - backlight_update_status(generic_backlight_device); > - mutex_unlock(&bd->ops_lock); > -} > -EXPORT_SYMBOL(genericbl_limit_intensity); > - > static const struct backlight_ops genericbl_ops = { > .options = BL_CORE_SUSPENDRESUME, > .get_brightness = genericbl_get_intensity, > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, December 16, 2013 11:24 PM, Josh Triplett wrote: > On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote: > > Removes unused function genericbl_limit_intensity() in > > backlight/generic_bl.c. > > > > This eliminates the following warning in backlight/generic_bl.c: > > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for > ‘genericbl_limit_intensity’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org> (+cc Andrew Morton, Eric Miao) Acked-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > > > drivers/video/backlight/generic_bl.c | 18 ------------------ > > 1 file changed, 18 deletions(-) > > > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > > index 5d8d652..67dfb93 100644 > > --- a/drivers/video/backlight/generic_bl.c > > +++ b/drivers/video/backlight/generic_bl.c > > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd) > > return genericbl_intensity; > > } > > > > -/* > > - * Called when the battery is low to limit the backlight intensity. > > - * If limit==0 clear any limit, otherwise limit the intensity > > - */ > > -void genericbl_limit_intensity(int limit) > > -{ > > - struct backlight_device *bd = generic_backlight_device; > > - > > - mutex_lock(&bd->ops_lock); > > - if (limit) > > - bd->props.state |= GENERICBL_BATTLOW; > > - else > > - bd->props.state &= ~GENERICBL_BATTLOW; > > - backlight_update_status(generic_backlight_device); > > - mutex_unlock(&bd->ops_lock); > > -} > > -EXPORT_SYMBOL(genericbl_limit_intensity); > > - > > static const struct backlight_ops genericbl_ops = { > > .options = BL_CORE_SUSPENDRESUME, > > .get_brightness = genericbl_get_intensity, > > -- > > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c index 5d8d652..67dfb93 100644 --- a/drivers/video/backlight/generic_bl.c +++ b/drivers/video/backlight/generic_bl.c @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd) return genericbl_intensity; } -/* - * Called when the battery is low to limit the backlight intensity. - * If limit==0 clear any limit, otherwise limit the intensity - */ -void genericbl_limit_intensity(int limit) -{ - struct backlight_device *bd = generic_backlight_device; - - mutex_lock(&bd->ops_lock); - if (limit) - bd->props.state |= GENERICBL_BATTLOW; - else - bd->props.state &= ~GENERICBL_BATTLOW; - backlight_update_status(generic_backlight_device); - mutex_unlock(&bd->ops_lock); -} -EXPORT_SYMBOL(genericbl_limit_intensity); - static const struct backlight_ops genericbl_ops = { .options = BL_CORE_SUSPENDRESUME, .get_brightness = genericbl_get_intensity,
Removes unused function genericbl_limit_intensity() in backlight/generic_bl.c. This eliminates the following warning in backlight/generic_bl.c: drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for ‘genericbl_limit_intensity’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> --- drivers/video/backlight/generic_bl.c | 18 ------------------ 1 file changed, 18 deletions(-)