From patchwork Wed Dec 18 21:55:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 3373441 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 79227C0D4A for ; Wed, 18 Dec 2013 21:55:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C8F71205E4 for ; Wed, 18 Dec 2013 21:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D33D7200E3 for ; Wed, 18 Dec 2013 21:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362Ab3LRVzq (ORCPT ); Wed, 18 Dec 2013 16:55:46 -0500 Received: from ring0.de ([91.143.88.219]:56953 "EHLO smtp.ring0.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753907Ab3LRVzm (ORCPT ); Wed, 18 Dec 2013 16:55:42 -0500 Received: from comu.ring0.de (unknown [127.0.0.1]) by smtp.ring0.de (Postfix) with ESMTP id C11AA2C58FEC; Wed, 18 Dec 2013 22:55:40 +0100 (CET) Received: (from spamd@localhost) by comu.ring0.de (8.13.8/8.13.8/Submit) id rBILtd81014082; Wed, 18 Dec 2013 22:55:39 +0100 X-Authentication-Warning: comu.ring0.de: spamd set sender to sre@debian.org using -f X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Date: Wed, 18 Dec 2013 22:55:37 +0100 From: Sebastian Reichel To: Tomi Valkeinen Cc: =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 0/4] OMAPDSS: DT support for N900 panel Message-ID: <20131218215536.GA23674@earth.universe> Mail-Followup-To: Tomi Valkeinen , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org References: <1386958650-2404-1-git-send-email-sre@debian.org> <52AFFF3F.7020807@ti.com> <20131217171412.GA10442@earth.universe> <52B089FE.8060704@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52B089FE.8060704@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Dec 17, 2013 at 07:29:34PM +0200, Tomi Valkeinen wrote: > >> I added N900 display DT support on top of my v2 series, including > >> pinmuxing. Can you check if it looks right and works? > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt > > > > I just tried it and it does not work. On a first look the pinmuxing > > looks fishy: 0x0d4 is muxed two times. > > Hmm, so it is. > > I'm not really familiar with SDI, I just muxed all the SDI pins, except > datapair3. I previously thought that there's only the data and clock > pairs for SDI, but the TRM revealed more sdi pins, so I included them. > It is well possible that these can be removed: > > 0x0d0 (PIN_OUTPUT | MUX_MODE1) /* dss_data18.sdi_vsync */ > 0x0d2 (PIN_OUTPUT | MUX_MODE1) /* dss_data19.sdi_hsync */ > 0x0d4 (PIN_OUTPUT | MUX_MODE1) /* dss_data20.sdi_den */ > 0x0d6 (PIN_OUTPUT | MUX_MODE1) /* dss_data21.sdi_stp */ Just removing the dss_data20.sdi_den pin was enough to get a working display. I don't know if the other pins are needed, because the display pins are already muxed correctly by the bootloader. -- Sebastian diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 39e5e50..33f29ac 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -163,7 +163,7 @@ 0x0d0 (PIN_OUTPUT | MUX_MODE1) /* dss_data18.sdi_vsync */ 0x0d2 (PIN_OUTPUT | MUX_MODE1) /* dss_data19.sdi_hsync */ - 0x0d4 (PIN_OUTPUT | MUX_MODE1) /* dss_data20.sdi_den */ + //0x0d4 (PIN_OUTPUT | MUX_MODE1) /* dss_data20.sdi_den */ 0x0d6 (PIN_OUTPUT | MUX_MODE1) /* dss_data21.sdi_stp */ 0x0d8 (PIN_OUTPUT | MUX_MODE1) /* dss_data22.sdi_clkp */ 0x0da (PIN_OUTPUT | MUX_MODE1) /* dss_data23.sdi_clkn */