From patchwork Tue May 13 21:26:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 4170561 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4003CBFF02 for ; Tue, 13 May 2014 21:27:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3716020340 for ; Tue, 13 May 2014 21:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E10412013D for ; Tue, 13 May 2014 21:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbaEMV0t (ORCPT ); Tue, 13 May 2014 17:26:49 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:54961 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753289AbaEMV0s (ORCPT ); Tue, 13 May 2014 17:26:48 -0400 Received: from 99-127-230-128.lightspeed.sntcca.sbcglobal.net ([99.127.230.128] helo=atomide.com) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1WkKDl-0002Fx-Dr; Tue, 13 May 2014 21:26:46 +0000 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/1r3g3y7WK2fJJ/qhPnDUR Date: Tue, 13 May 2014 14:26:39 -0700 From: Tony Lindgren To: Tomi Valkeinen Cc: linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/4] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support Message-ID: <20140513212639.GA18001@atomide.com> References: <1398815562-24113-1-git-send-email-tony@atomide.com> <1398815562-24113-4-git-send-email-tony@atomide.com> <5369EAE7.3030705@ti.com> <20140507150343.GA9502@atomide.com> <536A5920.1020908@ti.com> <20140507175919.GH9502@atomide.com> <20140508233300.GI2198@atomide.com> <536C924E.5000307@ti.com> <20140509153008.GC17814@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140509153008.GC17814@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Tony Lindgren [140509 08:31]: > * Tomi Valkeinen [140509 01:31]: > > On 09/05/14 02:33, Tony Lindgren wrote: > > > * Tony Lindgren [140507 11:00]: > > >> * Tomi Valkeinen [140507 09:03]: > > >>> On 07/05/14 18:03, Tony Lindgren wrote: > > >>>> > > >>>> BTW, I'm also personally fine with all five gpios showing in a single > > >>>> gpios property, I'm not too exited about naming anything in DT.. > > >>> > > >>> I don't have a strong opinion here. I don't have much experience with > > >>> DT, especially with making bindings compatible with other ones. > > >>> > > >>> I'd just forget the simple-panel, and have single gpio array. > > >> > > >> Well if it's a don't care flag for both of us, let's try to use > > >> the existing standard for simple-panel.txt and add mode-gpios > > >> property. I'll post a patch for that. > > > > > > Here's an updated version using enable-gpios, reset-gpios and > > > mode-gpios. So it follows simple-panel.txt and adds mode-gpios > > > that's currently specific to this panel only. > > > > > > Also updated for -EPROBE_DEFER handling, tested that by changing > > > one of the GPIOs to be a twl4030 GPIO. > > > > To speed things up a bit, I made the changes I suggested. Compile tested > > only. > > OK thanks did not get the penguin with it so need to look at it a bit > more. Here's this patch updated again for QVGA and VGA support and to use your panel remapping. I've also made sure the blanking works properly on evm-37xx and ldp. Regards, Tony 8< -------------------- From: Tony Lindgren Date: Mon, 28 Apr 2014 20:22:21 -0700 Subject: [PATCH] OMAPDSS: panel-sharp-ls037v7dw01: add device tree support Add device tree support for sharp-ls037v7dw01 panel. Note that this patch is using the remapping of the compatible flag as implemented by Tomi (that I do not like), but seems like that's currently needed to avoid redoing the panel bindings later on. And for the record, that has been agreed to be a temporary measure until the generic display bindings can be used by DSS. Signed-off-by: Tony Lindgren Signed-off-by: Tomi Valkeinen --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- /dev/null +++ b/Documentation/devicetree/bindings/video/sharp,ls037v7dw01.txt @@ -0,0 +1,44 @@ +SHARP LS037V7DW01 TFT-LCD panel +=================================== + +Required properties: +- compatible: "sharp,ls037v7dw01" + +Optional properties: +- label: a symbolic name for the panel +- enable-gpios: a GPIO spec for the optional enable pin + this pin is the INI pin as specified in the LS037V7DW01.pdf file. +- reset-gpios: a GPIO spec for the optional reset pin + this pin is the RESB pin as specified in the LS037V7DW01.pdf file. +- mode-gpios: a GPIO + ordered MO, LR, and UD as specified in the LS037V7DW01.pdf file. + +Required nodes: +- Video port for DPI input + +This panel can have zero to five GPIOs to configure +to change configuration between QVGA and VGA mode +and the scan direction. As these pins can be also +configured with external pulls, all the GPIOs are +considered optional with holes in the array. + +Example +------- + +Example when connected to a omap2+ based device: + +lcd0: display { + compatible = "sharp,ls037v7dw01"; + power-supply = <&lcd_3v3>; + enable-gpios = <&gpio5 24 GPIO_ACTIVE_HIGH>; /* gpio152, lcd INI */ + reset-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; /* gpio155, lcd RESB */ + mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ + &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ + &gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */ + + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; +}; --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -562,6 +562,7 @@ static const char * const dss_compat_conv_list[] __initconst = { "hdmi-connector", "panel-dpi", "panel-dsi-cm", + "sharp,ls037v7dw01", "sony,acx565akm", "svideo-connector", "ti,tfp410", --- a/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c @@ -12,15 +12,18 @@ #include #include #include +#include +#include #include #include - +#include #include