From patchwork Fri May 16 09:31:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daeseok Youn X-Patchwork-Id: 4189671 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 25458BFF02 for ; Fri, 16 May 2014 09:32:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 638672026F for ; Fri, 16 May 2014 09:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C3AB20251 for ; Fri, 16 May 2014 09:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258AbaEPJcB (ORCPT ); Fri, 16 May 2014 05:32:01 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:40799 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbaEPJcA (ORCPT ); Fri, 16 May 2014 05:32:00 -0400 Received: by mail-pa0-f41.google.com with SMTP id lj1so2326839pab.14 for ; Fri, 16 May 2014 02:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=N9HcWnZgII8d6EHed6DhIs6RpnOetTaGZqy5T/vjhOY=; b=ynaJlmH7vkEx/L0PVPx1nExr+BLoDqmKo6+1jGIK61IrhMkJoVfGAyeEI1sbZo3EMm 7yYQZciCIt9lcM/7oHMjrR61p58h4iNRMB+/A3N9FwFQHr+EX8QkWyfGJPYeBKYnZJil jjfk+WTMeERjtYZv1/9qc5dRbMArv8dNu4eTBprISVHbyipreKAK3iRKCWv1wtIBfR9/ sX0hs7yNIQ+bgYuooze0vjPtFcEVEKsRxoh/i3ACtdrku4j03oFFAiK83t/LvjwK4OdD I5vHi/cMvHCv4SkXF/ayGMxcmSoyOPmxujsidHuORshbuPiZ5ZZpBgoJmV2K0lER8fmm gCNw== X-Received: by 10.66.164.201 with SMTP id ys9mr19264316pab.40.1400232719896; Fri, 16 May 2014 02:31:59 -0700 (PDT) Received: from devel.8.8.4.4 ([220.149.236.66]) by mx.google.com with ESMTPSA id au4sm13536599pbc.10.2014.05.16.02.31.57 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 16 May 2014 02:31:59 -0700 (PDT) Date: Fri, 16 May 2014 18:31:23 +0900 From: Daeseok Youn To: plagnioj@jcrosoft.com Cc: tomi.valkeinen@ti.com, jg1.han@samsung.com, laurent.pinchart@ideasonboard.com, robdclark@gmail.com, daniel.vetter@ffwll.ch, Julia.Lawall@lip6.fr, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2] video : remove redundant error check Message-ID: <20140516093123.GA17245@devel.8.8.4.4> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't need to check "err" for printing info. And also use pr_info instead of printk. Signed-off-by: Daeseok Youn --- V2: removes unneeded lines for sending a patch drivers/video/fbdev/i810/i810_main.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c index bb674e4..15cb397 100644 --- a/drivers/video/fbdev/i810/i810_main.c +++ b/drivers/video/fbdev/i810/i810_main.c @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info) for (i = 0; i < par->ddc_num + 1; i++) { err = i810_probe_i2c_connector(info, &par->edid, i); - if (!err) + if (!err) { + pr_info("i810fb_init_pci: DDC probe successful\n"); break; + } } - if (!err) - printk("i810fb_init_pci: DDC probe successful\n"); - fb_edid_to_monspecs(par->edid, specs); if (specs->modedb == NULL)