diff mbox

video/mbx: indent some if statements

Message ID 20140611064535.GA16443@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter June 11, 2014, 6:45 a.m. UTC
Checkpatch.pl worries that we have left off the conditional bit because
it isn't indented correctly.

WARNING: suspect code indent for conditional statements (24, 24)

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Tomi Valkeinen June 23, 2014, 11:51 a.m. UTC | #1
On 11/06/14 09:45, Dan Carpenter wrote:
> Checkpatch.pl worries that we have left off the conditional bit because
> it isn't indented correctly.
> 
> WARNING: suspect code indent for conditional statements (24, 24)
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
> index 2bd52ed..698df954 100644
> --- a/drivers/video/fbdev/mbx/mbxfb.c
> +++ b/drivers/video/fbdev/mbx/mbxfb.c
> @@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
>  		case MBXFB_IOCS_PLANEORDER:
>  			if (copy_from_user(&porder, (void __user*)arg,
>  					sizeof(struct mbxfb_planeorder)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_planeorder(&porder);
>  
>  		case MBXFB_IOCS_ALPHA:
>  			if (copy_from_user(&alpha, (void __user*)arg,
>  					sizeof(struct mbxfb_alphaCtl)))
> -			return -EFAULT;
> +				return -EFAULT;
>  
>  			return mbxfb_ioctl_alphactl(&alpha);
>  
> 

Thanks, queued for 3.17.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
index 2bd52ed..698df954 100644
--- a/drivers/video/fbdev/mbx/mbxfb.c
+++ b/drivers/video/fbdev/mbx/mbxfb.c
@@ -628,14 +628,14 @@  static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
 		case MBXFB_IOCS_PLANEORDER:
 			if (copy_from_user(&porder, (void __user*)arg,
 					sizeof(struct mbxfb_planeorder)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_planeorder(&porder);
 
 		case MBXFB_IOCS_ALPHA:
 			if (copy_from_user(&alpha, (void __user*)arg,
 					sizeof(struct mbxfb_alphaCtl)))
-			return -EFAULT;
+				return -EFAULT;
 
 			return mbxfb_ioctl_alphactl(&alpha);