| Message ID | 20150319180556.GA12241@amitoj-Inspiron-3542 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Amitoj Kaur Chawla, On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > The edits have been made to add a space before the comment and the errors in > braces in the if-else statements. > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed > the C99 comments and errors in if-else indentation and braces. The previous patch isn't in the git repo yet so it doesn't have a commit id thus this one is wrong. You should've just made a v2 and made that change. I recommend you to look over this: http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in your local git repo, add that space and then when using `git format-patch` use the "--subject-prefix" option to add that it's a second version. Then after "---" you can say what was changed in the second version. For example (I'm sure you can think of a better one!): Signed-off-by: ... --- v2: added a space after a statement in a line where a coding style error was fixed. drivers/... > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 33fa456..bdf6a73 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -17,20 +17,17 @@ logical_chip_type_t getChipType(void) > char physicalRev; > logical_chip_type_t chip; > > - physicalID = devId750;/* either 0x718 or 0x750 */ > + physicalID = devId750; /* either 0x718 or 0x750 */ > physicalRev = revId750; > > if (physicalID == 0x718) { > chip = SM718; > - } > - else if (physicalID == 0x750) { > + } else if (physicalID == 0x750) { > chip = SM750; > /* SM750 and SM750LE are different in their revision ID only. */ > - if (physicalRev == SM750LE_REVISION_ID) { > + if (physicalRev == SM750LE_REVISION_ID) > chip = SM750LE; > - } > - } > - else { > + } else { > chip = SM_UNKNOWN; > } > >
On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevi?ius wrote: > Hi Amitoj Kaur Chawla, > > On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > > The edits have been made to add a space before the comment and the errors in > > braces in the if-else statements. > > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed > > the C99 comments and errors in if-else indentation and braces. > > The previous patch isn't in the git repo yet so it doesn't have a commit > id thus this one is wrong. You should've just made a v2 and made that > change. I recommend you to look over this: > http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in > your local git repo, add that space and then when using `git > format-patch` use the "--subject-prefix" option to add that it's a > second version. Then after "---" you can say what was changed in the > second version. For example (I'm sure you can think of a better one!): > > Signed-off-by: ... > --- > v2: added a space after a statement in a line where a coding style error > was fixed. > > drivers/... Yes, please resend both of these. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 33fa456..bdf6a73 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -17,20 +17,17 @@ logical_chip_type_t getChipType(void) char physicalRev; logical_chip_type_t chip; - physicalID = devId750;/* either 0x718 or 0x750 */ + physicalID = devId750; /* either 0x718 or 0x750 */ physicalRev = revId750; if (physicalID == 0x718) { chip = SM718; - } - else if (physicalID == 0x750) { + } else if (physicalID == 0x750) { chip = SM750; /* SM750 and SM750LE are different in their revision ID only. */ - if (physicalRev == SM750LE_REVISION_ID) { + if (physicalRev == SM750LE_REVISION_ID) chip = SM750LE; - } - } - else { + } else { chip = SM_UNKNOWN; }
The edits have been made to add a space before the comment and the errors in braces in the if-else statements. Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed the C99 comments and errors in if-else indentation and braces. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)