From patchwork Sat May 16 19:31:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michel von Czettritz X-Patchwork-Id: 6422061 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D2B2AC0432 for ; Sat, 16 May 2015 19:31:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B3A87204A7 for ; Sat, 16 May 2015 19:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D11CE204A2 for ; Sat, 16 May 2015 19:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbbEPTbd (ORCPT ); Sat, 16 May 2015 15:31:33 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38685 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbbEPTbc (ORCPT ); Sat, 16 May 2015 15:31:32 -0400 Received: by wicnf17 with SMTP id nf17so27814185wic.1 for ; Sat, 16 May 2015 12:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=R+uPhmBC4nwE503WF/sN9DTzvbIGkfUJ0YzKeah6i0Q=; b=QOSoyQ9LLT+ChVie5pwfzwJ/8XhIl5JwpL8ksbW+CE4TlD7hRkR0zwZctZ+BwvUunM ZYbpknqMZvHndVUnA4UDFNr/93xYs2qlWx7l5q6bWRlx6L4Yuq97Hk0bS8CgSIyrcUEu 8gu8JklifhRYYsoNBSow8WFJG9vmm6Qiu324MvnptlfJcqKZ2/5aToZgXJFQCJTJOm13 zzSKKCXkTaJ35i0RdEuIPxdFHxH9pJbhfM0zdGpjcgsq5S8S/KL+YLvk3VMmOK1jtMBL IP++6MMXNE/xBs533HNlgNhpZEUQ6Tirw/rbE1vDuLXNn1BSqUq4VOH2tVUMGKJlbJkS poog== X-Received: by 10.180.231.4 with SMTP id tc4mr8202782wic.27.1431804691644; Sat, 16 May 2015 12:31:31 -0700 (PDT) Received: from x230-arch (p4FDCFDAA.dip0.t-ipconnect.de. [79.220.253.170]) by mx.google.com with ESMTPSA id pz6sm8605254wjc.43.2015.05.16.12.31.30 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 May 2015 12:31:30 -0700 (PDT) Date: Sat, 16 May 2015 21:31:28 +0200 From: Michel von Czettritz To: sudipm.mukherjee@gmail.com Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH] staging: sm750fb: fix typo in fb_videomode Array Message-ID: <20150516193128.GA1534@x230-arch.Speedport_W_724V_01011602_00_001> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It appears that 'FB_SYNC_HOR_HIGH_ACT' should be assined to 'sync' and 'FB_VMODE_NONINTERLACED' is a flag for 'vmode'. In line 96 these flags are ORed and assigned to 'sync'. Since 'FB_VMODE_NONINTERLACED' is zero, 'sync' will stay the same, and due to C99 'vmode' is initialized to zero too. Therefore this doesn't have any implications for runtime-behavior, but seems to be semantically wrong. The Patch simply changes the | to a coma. Please check if this is correct. Signed-off-by: Michel von Czettritz --- drivers/staging/sm750fb/sm750.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 77310ff..8ff29c6 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -94,7 +94,8 @@ static const struct fb_videomode lynx750_ext[] = { FB_VMODE_NONINTERLACED}, {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3, - FB_SYNC_HOR_HIGH_ACT|FB_VMODE_NONINTERLACED}, + FB_SYNC_HOR_HIGH_ACT, + FB_VMODE_NONINTERLACED}, /* 1360 x 768 [1.77083:1] */ {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3,