| Message ID | 20150526152239.GA21887@x230-arch.club.entropia.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote: > As suggested by Sudip this patch removes the redundant 1360x768@60 > option from the fb_videomode struct array. this can be in the comments but should not be there in the commit message. regards sudip > The removed option and the option one it differ in a typo and a flag. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 27, 2015 at 11:59:21AM +0530, Sudip Mukherjee wrote: > On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote: > > As suggested by Sudip this patch removes the redundant 1360x768@60 > > option from the fb_videomode struct array. > this can be in the comments but should not be there in the commit message. > No no. It's fine. I sometimes give credit in the permanent log or in the meta comments depending on how much credit/blame is deserved. :P regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 69b18f3..d90b463 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -88,9 +88,6 @@ static const struct fb_videomode lynx750_ext[] = { FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED}, - {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3, - FB_SYNC_HOR_HIGH_ACT|FB_VMODE_NONINTERLACED}, - /* 1360 x 768 [1.77083:1] */ {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3, FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
As suggested by Sudip this patch removes the redundant 1360x768@60 option from the fb_videomode struct array. The removed option and the option one it differ in a typo and a flag. Signed-off-by: Michel von Czettritz <michel.von.czettritz@gmail.com> --- drivers/staging/sm750fb/sm750.c | 3 --- 1 file changed, 3 deletions(-)