| Message ID | 20150918184457.GA32636@goodgumbo.baconseed.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18/09/15 21:44, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hello, > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 > > Thanks, > Luis > > drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c > index 90cbc4c..c581231 100644 > --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c > +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c > @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = { > { .compatible = "omapdss,sony,acx565akm", }, > {}, > }; > +MODULE_DEVICE_TABLE(of, acx565akm_of_match); > > static struct spi_driver acx565akm_driver = { > .driver = { > Thanks, queued for 4.3 fixes. Tomi
On 24/09/15 13:17, Tomi Valkeinen wrote: > > > On 18/09/15 21:44, Luis de Bethencourt wrote: >> This platform driver has a OF device ID table but the OF module >> alias information is not created so module autoloading won't work. >> >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> >> --- >> >> Hello, >> >> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export >> that information so modules have the correct aliases built-in and >> autoloading works correctly. >> >> A longer explanation by Javier Canillas can be found here: >> https://lkml.org/lkml/2015/7/30/519 >> >> Thanks, >> Luis >> >> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c >> index 90cbc4c..c581231 100644 >> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c >> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c >> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = { >> { .compatible = "omapdss,sony,acx565akm", }, >> {}, >> }; >> +MODULE_DEVICE_TABLE(of, acx565akm_of_match); >> >> static struct spi_driver acx565akm_driver = { >> .driver = { >> > > Thanks, queued for 4.3 fixes. Oh, there was an earlier patch from Javier already posted. So I'll pick that one instead. Tomi
diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c index 90cbc4c..c581231 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = { { .compatible = "omapdss,sony,acx565akm", }, {}, }; +MODULE_DEVICE_TABLE(of, acx565akm_of_match); static struct spi_driver acx565akm_driver = { .driver = {
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 + 1 file changed, 1 insertion(+)