From patchwork Fri Jul 15 20:32:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9232689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 021B060868 for ; Fri, 15 Jul 2016 20:35:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E76CD26861 for ; Fri, 15 Jul 2016 20:35:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DADD427C0B; Fri, 15 Jul 2016 20:35:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A034826861 for ; Fri, 15 Jul 2016 20:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbcGOUfJ (ORCPT ); Fri, 15 Jul 2016 16:35:09 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:63748 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbcGOUfI (ORCPT ); Fri, 15 Jul 2016 16:35:08 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0MSFaB-1bmaeR0q2V-00TR5A; Fri, 15 Jul 2016 22:32:32 +0200 From: Arnd Bergmann To: Andrew Morton Cc: Arnd Bergmann , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fbmon: remove unused function argument Date: Fri, 15 Jul 2016 22:32:15 +0200 Message-Id: <20160715203229.1771162-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:dOQtwEkfTfC5SNk6CmW6uDMov6vrBS4vinUxkSifsjl97zX7M+B Y/jCJOcCNAdNMMqLiURL1OGF3BdsAtOxsE3E6OU/AAhn1FbOmdfpr/cQPAkFzrUXeQaERLK G4yJoAb1peMCkCC6/+Vq5fP70IAL4aa70wQuoy9/ryaTBZ6YAoeUzpkvfc2so+sXpjA+ili aN8ksaCDP2K61ax+VDmsw== X-UI-Out-Filterresults: notjunk:1; V01:K0:LTijpTV8FKQ=:0v3Soj01TsJjUIjudpdnQ/ 8pgKaKmqq0FZc4uzjkPw1+Gxabb6+MZHoEjFpdMn8cHlELqIXYDDUy9C/+SRodTBPviV5xrG4 4UIvNJX2HTaejtolMuT4ZEM+HRGCLOaTW3TrBGV/VfgAyqEVkQaBGEuZ6dNg034tGmaiFRkfm NzTLxARVKnwntpQ+2QWmop7vxa2qVFXGCGgEmXyZ/22jv9BwVmOG1jpqc3/0O5iwmquuhadcL r2CCq4yAQAMfe1eXKooJTlWDBKmMsJLYDRnh3BnnLRISKfoyEAwMvEkVyiZ273gk+8fJWDLfx l0BcjkGREOXWl68Yiob4NAdJbpN8MTQthfT4UQNRcXyM0FImV8sEiDjbg47Pxj3i58ymO5kHi vMJ2VmrWJeXrZb1lgKKK+tdUT0Fw3wzBrCkPbzy5aJlJm1nSHn6eeGNAc41EeZnB1kGqLjjit uBdkrXatGMaoYHDadN+T2qgnTGADRdh2UTDj1L1hP96akOA8g6zAzobFTKHBwyAuovPEyjrd/ Sh2lH6oUfsS0ytXHYIq0ba54uBwpzlqc/vmNYEWkZxKvuanb4eD+2TjXcZD/EeuUkHubfEs3D P+mmGBWseBB0UKawH6e1+6Ejzju0Pxi7i5O2EYa2UarSK3u4wA/pzf8AJZdrmjijdm4mon+tA 9G8YuteEvTVLejTEkGgzvbi7Xjf0rZF5rDS58cWwv6Hy29oSQ+sCXWYrzKcaZVMX/0hM= Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When building with "make W=1", we get a warning about an empty stub function that does nothing but reassign its one of its arguments: drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_to_monspecs': drivers/video/fbdev/core/fbmon.c:1497:67: error: parameter 'specs' set but not used [-Werror=unused-but-set-parameter] We can simply make that function completely empty to avoid the warning. Signed-off-by: Arnd Bergmann --- I sent this patch on June 16 when this warning was only for "make W=1", but never got a reply from the fbdev maintainers. Now Andrew merged a patch to have the warning at the default level, maybe he can apply this as well. --- drivers/video/fbdev/core/fbmon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 55e39e822b79..eaa6bab21839 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c @@ -1496,7 +1496,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) } void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs) { - specs = NULL; } void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs) {