From patchwork Tue Aug 2 12:06:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9257793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B4D7F60754 for ; Tue, 2 Aug 2016 14:43:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A54F22860E for ; Tue, 2 Aug 2016 14:43:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 947DA28615; Tue, 2 Aug 2016 14:43:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10DA42860E for ; Tue, 2 Aug 2016 14:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965163AbcHBMvk (ORCPT ); Tue, 2 Aug 2016 08:51:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:2673 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965108AbcHBMnx (ORCPT ); Tue, 2 Aug 2016 08:43:53 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 02 Aug 2016 05:43:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033603494" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by fmsmga002.fm.intel.com with ESMTP; 02 Aug 2016 05:43:49 -0700 From: Baole Ni To: michael.hennerich@analog.com, jingoohan1@gmail.com, lee.jones@linaro.org, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mathias.nyman@linux.intel.com, stern@rowland.harvard.edu, oneukum@suse.com Subject: [PATCH 0993/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:06:11 +0800 Message-Id: <20160802120611.16275-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/video/backlight/adp5520_bl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c index dd88ba1..cedd1d6 100644 --- a/drivers/video/backlight/adp5520_bl.c +++ b/drivers/video/backlight/adp5520_bl.c @@ -187,7 +187,7 @@ static ssize_t adp5520_bl_dark_max_store(struct device *dev, { return adp5520_store(dev, buf, count, ADP5520_DARK_MAX); } -static DEVICE_ATTR(dark_max, 0664, adp5520_bl_dark_max_show, +static DEVICE_ATTR(dark_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_dark_max_show, adp5520_bl_dark_max_store); static ssize_t adp5520_bl_office_max_show(struct device *dev, @@ -202,7 +202,7 @@ static ssize_t adp5520_bl_office_max_store(struct device *dev, { return adp5520_store(dev, buf, count, ADP5520_OFFICE_MAX); } -static DEVICE_ATTR(office_max, 0664, adp5520_bl_office_max_show, +static DEVICE_ATTR(office_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_office_max_show, adp5520_bl_office_max_store); static ssize_t adp5520_bl_daylight_max_show(struct device *dev, @@ -224,7 +224,7 @@ static ssize_t adp5520_bl_daylight_max_store(struct device *dev, return adp5520_store(dev, buf, count, ADP5520_DAYLIGHT_MAX); } -static DEVICE_ATTR(daylight_max, 0664, adp5520_bl_daylight_max_show, +static DEVICE_ATTR(daylight_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_daylight_max_show, adp5520_bl_daylight_max_store); static ssize_t adp5520_bl_dark_dim_show(struct device *dev, @@ -239,7 +239,7 @@ static ssize_t adp5520_bl_dark_dim_store(struct device *dev, { return adp5520_store(dev, buf, count, ADP5520_DARK_DIM); } -static DEVICE_ATTR(dark_dim, 0664, adp5520_bl_dark_dim_show, +static DEVICE_ATTR(dark_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_dark_dim_show, adp5520_bl_dark_dim_store); static ssize_t adp5520_bl_office_dim_show(struct device *dev, @@ -254,7 +254,7 @@ static ssize_t adp5520_bl_office_dim_store(struct device *dev, { return adp5520_store(dev, buf, count, ADP5520_OFFICE_DIM); } -static DEVICE_ATTR(office_dim, 0664, adp5520_bl_office_dim_show, +static DEVICE_ATTR(office_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_office_dim_show, adp5520_bl_office_dim_store); static ssize_t adp5520_bl_daylight_dim_show(struct device *dev, @@ -269,7 +269,7 @@ static ssize_t adp5520_bl_daylight_dim_store(struct device *dev, { return adp5520_store(dev, buf, count, ADP5520_DAYLIGHT_DIM); } -static DEVICE_ATTR(daylight_dim, 0664, adp5520_bl_daylight_dim_show, +static DEVICE_ATTR(daylight_dim, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adp5520_bl_daylight_dim_show, adp5520_bl_daylight_dim_store); static struct attribute *adp5520_bl_attributes[] = {