From patchwork Tue Aug 2 12:09:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9257579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E19AF6089F for ; Tue, 2 Aug 2016 14:11:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBC262853D for ; Tue, 2 Aug 2016 14:11:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF7252853B; Tue, 2 Aug 2016 14:11:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE90C28539 for ; Tue, 2 Aug 2016 14:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933817AbcHBOLI (ORCPT ); Tue, 2 Aug 2016 10:11:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:19406 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965743AbcHBM5Q (ORCPT ); Tue, 2 Aug 2016 08:57:16 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 02 Aug 2016 05:46:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028286920" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 05:46:52 -0700 From: Baole Ni To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1022/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:09:13 +0800 Message-Id: <20160802120913.18243-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/video/fbdev/w100fb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/w100fb.c b/drivers/video/fbdev/w100fb.c index 10951c8..2e6db35 100644 --- a/drivers/video/fbdev/w100fb.c +++ b/drivers/video/fbdev/w100fb.c @@ -110,7 +110,7 @@ static ssize_t flip_store(struct device *dev, struct device_attribute *attr, con return count; } -static DEVICE_ATTR(flip, 0644, flip_show, flip_store); +static DEVICE_ATTR(flip, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, flip_show, flip_store); static ssize_t w100fb_reg_read(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { @@ -121,7 +121,7 @@ static ssize_t w100fb_reg_read(struct device *dev, struct device_attribute *attr return count; } -static DEVICE_ATTR(reg_read, 0200, NULL, w100fb_reg_read); +static DEVICE_ATTR(reg_read, S_IWUSR, NULL, w100fb_reg_read); static ssize_t w100fb_reg_write(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { @@ -136,7 +136,7 @@ static ssize_t w100fb_reg_write(struct device *dev, struct device_attribute *att return count; } -static DEVICE_ATTR(reg_write, 0200, NULL, w100fb_reg_write); +static DEVICE_ATTR(reg_write, S_IWUSR, NULL, w100fb_reg_write); static ssize_t fastpllclk_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -166,7 +166,7 @@ static ssize_t fastpllclk_store(struct device *dev, struct device_attribute *att return count; } -static DEVICE_ATTR(fastpllclk, 0644, fastpllclk_show, fastpllclk_store); +static DEVICE_ATTR(fastpllclk, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, fastpllclk_show, fastpllclk_store); /* * Some touchscreens need hsync information from the video driver to