From patchwork Fri Sep 2 19:35:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: phil.turnbull@oracle.com X-Patchwork-Id: 9311569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 390B260772 for ; Fri, 2 Sep 2016 19:39:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23DE829835 for ; Fri, 2 Sep 2016 19:39:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 13C972984D; Fri, 2 Sep 2016 19:39:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B8E929835 for ; Fri, 2 Sep 2016 19:39:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932661AbcIBTjr (ORCPT ); Fri, 2 Sep 2016 15:39:47 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23584 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932555AbcIBTjq (ORCPT ); Fri, 2 Sep 2016 15:39:46 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u82Jdaii030101 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 Sep 2016 19:39:37 GMT Received: from basil.us.oracle.com (dhcp-amer-vpn-adc-anyconnect-10-154-150-64.vpn.oracle.com [10.154.150.64]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u82JdYX3018466; Fri, 2 Sep 2016 19:39:35 GMT From: Phil Turnbull To: devel@driverdev.osuosl.org Cc: linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Teddy Wang , Sudip Mukherjee , Phil Turnbull Subject: [PATCH] staging: sm750fb: Correctly set CLOCK_PHASE bit of display controller. Date: Fri, 2 Sep 2016 15:35:31 -0400 Message-Id: <20160902193531.12057-1-phil.turnbull@oracle.com> X-Mailer: git-send-email 2.9.0.rc2 X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 6fba39cf32a3 ("staging: sm750fb: use BIT macro for PANEL_DISPLAY_CTRL single-bit fields") accidentally changed the CLOCK_PHASE logic from '|=' to '=' which clears all the previously set bits. Fixes: 6fba39cf32a3 ("staging: sm750fb: use BIT macro for PANEL_DISPLAY_CTRL single-bit fields") Signed-off-by: Phil Turnbull --- drivers/staging/sm750fb/ddk750_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index ccb4e067661a..e29d4bd5dcec 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -63,7 +63,7 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT); /* Set bit 14 of display controller */ - dispControl = DISPLAY_CTRL_CLOCK_PHASE; + dispControl |= DISPLAY_CTRL_CLOCK_PHASE; POKE32(CRT_DISPLAY_CTRL, dispControl);