From patchwork Sun Nov 27 21:11:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Ghittino X-Patchwork-Id: 9448917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E21A60235 for ; Sun, 27 Nov 2016 21:11:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BECC203B9 for ; Sun, 27 Nov 2016 21:11:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F4192074F; Sun, 27 Nov 2016 21:11:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 404C8203B9 for ; Sun, 27 Nov 2016 21:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbcK0VL2 (ORCPT ); Sun, 27 Nov 2016 16:11:28 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34191 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbcK0VL2 (ORCPT ); Sun, 27 Nov 2016 16:11:28 -0500 Received: by mail-wm0-f68.google.com with SMTP id g23so15990946wme.1 for ; Sun, 27 Nov 2016 13:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=FJHBnQ05DSlZGXAfTAUanYDLkj2o4xeaiPqyNf32OHE=; b=ZqO2mMs5rdgKSz/jjS8xwv+ADNuz4RSgV3qKQQb+M76okW10CuaBhXJiAVmKsPYrrM 3OdUfBZyVLlMtRqWHeivdY3CYQMisNKQm2x7Gz5wxrmym01WQN089rq1FLUM9MRwbz3b pIxNL/FYzKvpaC6Biam/ODyRpuxZjieHXP5VPC7Kw3HUGgo2Vg7MjFqEarRFXQ9LsirL sB00+BG32efeXcN0UhrtEe4s9NywhR+XYkmw5Ul7At1vlRjrih8OuhR3nlblubojKPKR Og/GwabUnD6xSiFvr+VzPyJEX5b2hzOyK34al1KLc3Vp0A+LdIZCmvZ6Z0TGz7agINaG XTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=FJHBnQ05DSlZGXAfTAUanYDLkj2o4xeaiPqyNf32OHE=; b=P9rLzdCpRncP2T8DulcUH+t91gCvCBy++NaSQAdX1jjhoUtr/9BbSZB8wKiv1KaAix sURX7iDcEnaluJaNokMlZjJwCNeNrDtuciOZ27djiaTlm1IvPS6NeVt/nrUsl1l9hvHu 9xf/Q27CQK7YFYMlEyppRIhQwoaidyRabw9VAkKO9F3jiJssF+h08/t3nC6iO5ElmIzT u6hv4Wk6BvzOrM0ecj5BPTwAifmnli5+YU4UgM4Cwj7EJ6Pl/DCCuXpdx+T4SK4ZpQZo VWCuH7nGykuXLBMCbIhHCdr2gykkcEJQ9srIh02f2D0nBsa7THa2T8PRZ2sTJZnGOjNY lHzg== X-Gm-Message-State: AKaTC03I29nW+WFayHA0BTmQaLwE8cfi7TPOWOsTEgs3X4GMiG1Z6hZ3yJZblRhV+V+c0g== X-Received: by 10.28.130.137 with SMTP id e131mr15944392wmd.21.1480281086433; Sun, 27 Nov 2016 13:11:26 -0800 (PST) Received: from myhd3 ([5.170.28.236]) by smtp.gmail.com with ESMTPSA id ct7sm40691524wjc.2.2016.11.27.13.11.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Nov 2016 13:11:25 -0800 (PST) Date: Sun, 27 Nov 2016 22:11:18 +0100 From: Andrea Ghittino To: devel@driverdev.osuosl.org Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com Subject: [PATCH] staging: sm750fb: fix function definition argument style warning Message-ID: <20161127211107.GA4262@myhd3> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes sm750fb function definition argument style warning found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index e97e859..30653dd 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -91,6 +91,6 @@ void sm750_set_chip_type(unsigned short devId, char revId); unsigned int sm750_calc_pll_value(unsigned int request, struct pll_value *pll); unsigned int sm750_format_pll_reg(struct pll_value *pPLL); unsigned int ddk750_get_vm_size(void); -int ddk750_init_hw(struct initchip_param *); +int ddk750_init_hw(struct initchip_param *pInitParam); #endif diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h index 8abca88..c4a4cbf 100644 --- a/drivers/staging/sm750fb/ddk750_display.h +++ b/drivers/staging/sm750fb/ddk750_display.h @@ -107,6 +107,6 @@ typedef enum _disp_output_t { } disp_output_t; -void ddk750_setLogicalDispOut(disp_output_t); +void ddk750_setLogicalDispOut(disp_output_t output); #endif diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index e846dc2..bdcfe69 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -35,7 +35,7 @@ typedef struct _mode_parameter_t { } mode_parameter_t; -int ddk750_setModeTiming(mode_parameter_t *, clock_type_t); +int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock); #endif diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index eb088b0..6de0458 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -14,7 +14,7 @@ DPMS_t; (PEEK32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \ } -void ddk750_set_dpms(DPMS_t); +void ddk750_set_dpms(DPMS_t state); void sm750_set_power_mode(unsigned int powerMode); void sm750_set_current_gate(unsigned int gate); diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 28f4b9b..3b7bced 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -184,19 +184,23 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) } int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); -int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *); -void hw_sm750_initAccel(struct sm750_dev *); +int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); +void hw_sm750_initAccel(struct sm750_dev *sm750_dev); int hw_sm750_deWait(void); int hw_sm750le_deWait(void); -int hw_sm750_output_setMode(struct lynxfb_output*, struct fb_var_screeninfo*, - struct fb_fix_screeninfo*); -int hw_sm750_crtc_checkMode(struct lynxfb_crtc*, struct fb_var_screeninfo*); -int hw_sm750_crtc_setMode(struct lynxfb_crtc*, struct fb_var_screeninfo*, - struct fb_fix_screeninfo*); -int hw_sm750_setColReg(struct lynxfb_crtc*, ushort, ushort, ushort, ushort); -int hw_sm750_setBLANK(struct lynxfb_output*, int); -int hw_sm750le_setBLANK(struct lynxfb_output*, int); +int hw_sm750_output_setMode(struct lynxfb_output *output, + struct fb_var_screeninfo *var, + struct fb_fix_screeninfo *fix); +int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, + struct fb_var_screeninfo* var); +int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, + struct fb_var_screeninfo *var, + struct fb_fix_screeninfo *fix); +int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index, + ushort red, ushort green , ushort blue); +int hw_sm750_setBLANK(struct lynxfb_output *output, int blank); +int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank); int hw_sm750_pan_display(struct lynxfb_crtc *crtc, const struct fb_var_screeninfo *var, const struct fb_info *info);