| Message ID | 20161128124850.14383-1-tklauser@distanz.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Isn, 2016-11-28 at 13:48 +0100, Tobias Klauser wrote: > The allyesconfig/allmodconfig build currently fails on nios2 with the > following linker error: > > drivers/built-in.o: In function `vgacon_switch': > vgacon.c:(.text+0x34750): undefined reference to `screen_info' > vgacon.c:(.text+0x34758): undefined reference to `screen_info' > drivers/built-in.o: In function `vgacon_resize': > vgacon.c:(.text+0x349b4): undefined reference to `screen_info' > vgacon.c:(.text+0x349b8): undefined reference to `screen_info' > drivers/built-in.o: In function `vgacon_save_screen': > vgacon.c:(.text+0x34ae8): undefined reference to `screen_info' > drivers/built-in.o:vgacon.c:(.text+0x34aec): more undefined > references to `screen_info' follow > > Since the nios2 architecture doesn't define the screen_info symbol. > > Fix it by disabling VGA console for nios2. > > Cc: Ley Foon Tan <lftan@altera.com> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Hi Tobias Sudip sent this patch in early November before to add screen_info in nios2. However, I don't have hardware to test the settings used in this patch is working or not. We only need either one of these 2 patches. Do you have any comment? https://patchwork.kernel.org/patch/9420315/ Regards Ley Foon > --- > drivers/video/console/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/console/Kconfig > b/drivers/video/console/Kconfig > index 38da6e299149..f63a022689b5 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -9,7 +9,7 @@ config VGA_CONSOLE > depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV > && \ > !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS > && \ > (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || > ARCH_NETWINDER) && \ > - !ARM64 && !ARC && !MICROBLAZE > + !ARM64 && !ARC && !MICROBLAZE && !NIOS2 > default y > help > Saying Y here will allow you to use Linux in text mode > through a > -- > 2.11.0.rc0.7.gbe5a750 > > > > ________________________________ > > Confidentiality Notice. > This message may contain information that is confidential or > otherwise protected from disclosure. If you are not the intended > recipient, you are hereby notified that any use, disclosure, > dissemination, distribution, or copying of this message, or any > attachments, is strictly prohibited. If you have received this > message in error, please advise the sender by reply e-mail, and > delete the message and any attachments. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-12-06 at 04:29:12 +0100, Ley Foon Tan <ley.foon.tan@intel.com> wrote: > On Isn, 2016-11-28 at 13:48 +0100, Tobias Klauser wrote: > > The allyesconfig/allmodconfig build currently fails on nios2 with the > > following linker error: > > > > drivers/built-in.o: In function `vgacon_switch': > > vgacon.c:(.text+0x34750): undefined reference to `screen_info' > > vgacon.c:(.text+0x34758): undefined reference to `screen_info' > > drivers/built-in.o: In function `vgacon_resize': > > vgacon.c:(.text+0x349b4): undefined reference to `screen_info' > > vgacon.c:(.text+0x349b8): undefined reference to `screen_info' > > drivers/built-in.o: In function `vgacon_save_screen': > > vgacon.c:(.text+0x34ae8): undefined reference to `screen_info' > > drivers/built-in.o:vgacon.c:(.text+0x34aec): more undefined > > references to `screen_info' follow > > > > Since the nios2 architecture doesn't define the screen_info symbol. > > > > Fix it by disabling VGA console for nios2. > > > > Cc: Ley Foon Tan <lftan@altera.com> > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > Sudip sent this patch in early November before to add screen_info in > nios2. However, I don't have hardware to test the settings used in this > patch is working or not. We only need either one of these 2 patches. Do > you have any comment? > https://patchwork.kernel.org/patch/9420315/ I don't have any hardware to test this on either, so I thought this was the safest fix. If we're going to define screen_info, I'd suggest to do it in a similar manner as e.g. tile, sh, score, ia64, hexagon, cris, c6x and unicore32. They all just define an struct screen_info screen_info; without any of the members set explicitely. I think they should only be set, once they actually have been tested on hardware. In any case, I'd propose to apply either one of the solutions for 4.9 in order to fix the build breakage. Thanks Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sel, 2016-12-06 at 08:04 +0100, Tobias Klauser wrote: > On 2016-12-06 at 04:29:12 +0100, Ley Foon Tan <ley.foon.tan@intel.com > > wrote: > > > > On Isn, 2016-11-28 at 13:48 +0100, Tobias Klauser wrote: > > > > > > The allyesconfig/allmodconfig build currently fails on nios2 with > > > the > > > following linker error: > > > > > > drivers/built-in.o: In function `vgacon_switch': > > > vgacon.c:(.text+0x34750): undefined reference to `screen_info' > > > vgacon.c:(.text+0x34758): undefined reference to `screen_info' > > > drivers/built-in.o: In function `vgacon_resize': > > > vgacon.c:(.text+0x349b4): undefined reference to `screen_info' > > > vgacon.c:(.text+0x349b8): undefined reference to `screen_info' > > > drivers/built-in.o: In function `vgacon_save_screen': > > > vgacon.c:(.text+0x34ae8): undefined reference to `screen_info' > > > drivers/built-in.o:vgacon.c:(.text+0x34aec): more undefined > > > references to `screen_info' follow > > > > > > Since the nios2 architecture doesn't define the screen_info > > > symbol. > > > > > > Fix it by disabling VGA console for nios2. > > > > > > Cc: Ley Foon Tan <lftan@altera.com> > > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > > Sudip sent this patch in early November before to add screen_info > > in > > nios2. However, I don't have hardware to test the settings used in > > this > > patch is working or not. We only need either one of these 2 > > patches. Do > > you have any comment? > > https://patchwork.kernel.org/patch/9420315/ > I don't have any hardware to test this on either, so I thought this > was > the safest fix. > > If we're going to define screen_info, I'd suggest to do it in a > similar > manner as e.g. tile, sh, score, ia64, hexagon, cris, c6x and > unicore32. > They all just define an struct screen_info screen_info; without any > of > the members set explicitely. I think they should only be set, once > they > actually have been tested on hardware. > > In any case, I'd propose to apply either one of the solutions for 4.9 > in > order to fix the build breakage. Okay, I will follow other architectures approach. Just add the declaration for screen_info: struct screen_info screen_info; Thanks. Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index 38da6e299149..f63a022689b5 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -9,7 +9,7 @@ config VGA_CONSOLE depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \ !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \ (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ - !ARM64 && !ARC && !MICROBLAZE + !ARM64 && !ARC && !MICROBLAZE && !NIOS2 default y help Saying Y here will allow you to use Linux in text mode through a
The allyesconfig/allmodconfig build currently fails on nios2 with the following linker error: drivers/built-in.o: In function `vgacon_switch': vgacon.c:(.text+0x34750): undefined reference to `screen_info' vgacon.c:(.text+0x34758): undefined reference to `screen_info' drivers/built-in.o: In function `vgacon_resize': vgacon.c:(.text+0x349b4): undefined reference to `screen_info' vgacon.c:(.text+0x349b8): undefined reference to `screen_info' drivers/built-in.o: In function `vgacon_save_screen': vgacon.c:(.text+0x34ae8): undefined reference to `screen_info' drivers/built-in.o:vgacon.c:(.text+0x34aec): more undefined references to `screen_info' follow Since the nios2 architecture doesn't define the screen_info symbol. Fix it by disabling VGA console for nios2. Cc: Ley Foon Tan <lftan@altera.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- drivers/video/console/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)