From patchwork Sat Dec 17 01:02:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9478783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A73A360827 for ; Sat, 17 Dec 2016 01:02:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 991B32870F for ; Sat, 17 Dec 2016 01:02:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8DC6C28736; Sat, 17 Dec 2016 01:02:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D4492870F for ; Sat, 17 Dec 2016 01:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933583AbcLQBCF (ORCPT ); Fri, 16 Dec 2016 20:02:05 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:35098 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933538AbcLQBCE (ORCPT ); Fri, 16 Dec 2016 20:02:04 -0500 Received: by mail-pg0-f52.google.com with SMTP id p66so37706281pga.2 for ; Fri, 16 Dec 2016 17:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=wmr8rPFdY6tDwp68vbvZX+Mc081xCepygTwGp4Kg9Uw=; b=jMZOX02hX+zLJw0DwZukMTDMYDZ7xd+/E2IVd+jPii+bBt+AzS/Q69IPV3XXhKcx1i CFZq1UccbSozasCe/2ArUQQUYOPbZ0+LyTSdc+v486xwGURwqmcvR833mA2lTRa97tnw 4m4ZozSAxL4h852F8XpldznN6b1dx2wFbrYf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=wmr8rPFdY6tDwp68vbvZX+Mc081xCepygTwGp4Kg9Uw=; b=UgHXy+a3qTdaSo9fkmUsVEy7DkMrPMq9/N3oypDkzPFXMkXmx/Cj8P8va9I4Xgp1pJ ULwoGjVplk3GyqsmpI87sUjb0iaOgABVpHLIIwFJzl81TpYwF7VZKed6FBlRYiHavzGE +kb5UX38Ugoth1h+aQS7fWV6Zrj9jPBiFVmj5FwYzKs2Q6r//ehS24C2wJ0vWleQCLs4 4rKLQneof9N9LW4AaENFbUMXbErdeCSWBqqlIwKMja6suvSX7CRUcDy3hfQYTiWC9p0N O2wNW6zPbl5wIuoZ8iEswDpWLdC1hnBONBedP0ywucLfrrhoBlGyw6I7m4c7vFdKrKag YbCQ== X-Gm-Message-State: AKaTC03qjnXKT4i88x2CqjjVgMj076vZdf9lvU/uyLpX34wE6hEDvqbbpgNSdI6/c5gI02N8 X-Received: by 10.98.58.132 with SMTP id v4mr5743344pfj.7.1481936524002; Fri, 16 Dec 2016 17:02:04 -0800 (PST) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id a24sm14375666pfh.57.2016.12.16.17.02.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 17:02:03 -0800 (PST) Date: Fri, 16 Dec 2016 17:02:03 -0800 From: Kees Cook To: linux-kernel@vger.kernel.org Cc: Kees Cook , linux-fbdev@vger.kernel.org Subject: [PATCH] video: fbdev: sh_mobile_lcdcfb: use designated initializers Message-ID: <20161217010203.GA140420@beast> MIME-Version: 1.0 Content-Disposition: inline Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook Reviewed-by: Geert Uytterhoeven --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index 82c0a8caa9b8..42499a1afa07 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -439,9 +439,9 @@ static unsigned long lcdc_sys_read_data(void *handle) } static struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = { - lcdc_sys_write_index, - lcdc_sys_write_data, - lcdc_sys_read_data, + .write_index = lcdc_sys_write_index, + .write_data = lcdc_sys_write_data, + .read_data = lcdc_sys_read_data, }; static int sh_mobile_lcdc_sginit(struct fb_info *info,