From patchwork Wed Dec 21 03:27:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 9482467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1F0E6082B for ; Wed, 21 Dec 2016 03:27:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1E9B280FC for ; Wed, 21 Dec 2016 03:27:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 96BFF28138; Wed, 21 Dec 2016 03:27:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DA7B28118 for ; Wed, 21 Dec 2016 03:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445AbcLUD11 (ORCPT ); Tue, 20 Dec 2016 22:27:27 -0500 Received: from mleia.com ([178.79.152.223]:49266 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756942AbcLUD10 (ORCPT ); Tue, 20 Dec 2016 22:27:26 -0500 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 5D317386B62; Wed, 21 Dec 2016 03:27:25 +0000 (GMT) From: Vladimir Zapolskiy To: Tomi Valkeinen , Russell King Cc: Linus Walleij , Arnd Bergmann , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] video: ARM CLCD: add support of an optional GPIO to enable panel Date: Wed, 21 Dec 2016 05:27:17 +0200 Message-Id: <20161221032717.13154-5-vz@mleia.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161221032717.13154-1-vz@mleia.com> References: <20161221032717.13154-1-vz@mleia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20161221_032725_418638_65EAE98B X-CRM114-Status: GOOD ( 16.10 ) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The change adds handling of "enable-gpios" property of panel-dpi device node used with an ARM CLCD controller, note that the property already has a description in display/panel/panel-dpi.txt documentation and it founds practical usage while describing some panel devices connected to other types of display controllers. Signed-off-by: Vladimir Zapolskiy --- drivers/video/fbdev/amba-clcd.c | 29 +++++++++++++++++++++++++++++ include/linux/amba/clcd.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index 0fab92c..0bb8646 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -87,6 +88,9 @@ static void clcdfb_disable(struct clcd_fb *fb) writel(val, fb->regs + fb->off_cntl); } + if (fb->panel->enable_gpio) + gpiod_set_value_cansleep(fb->panel->enable_gpio, 0); + /* * Disable CLCD clock source. */ @@ -106,6 +110,9 @@ static void clcdfb_enable(struct clcd_fb *fb, u32 cntl) clk_enable(fb->clk); } + if (fb->panel->enable_gpio) + gpiod_set_value_cansleep(fb->panel->enable_gpio, 1); + /* * Bring up by first enabling.. */ @@ -624,6 +631,24 @@ static int clcdfb_snprintf_mode(char *buf, int size, struct fb_videomode *mode) mode->refresh); } +static int clcdfb_of_get_enable_gpio(struct device *dev, + struct device_node *panel, + struct clcd_panel *clcd_panel) +{ + int err; + + clcd_panel->enable_gpio = devm_get_gpiod_from_child(dev, "enable", + &panel->fwnode); + if (IS_ERR(clcd_panel->enable_gpio)) { + err = PTR_ERR(clcd_panel->enable_gpio); + clcd_panel->enable_gpio = NULL; + if (err != -ENOENT) + return err; + } + + return 0; +} + static int clcdfb_of_get_backlight(struct device_node *panel, struct clcd_panel *clcd_panel) { @@ -781,6 +806,10 @@ static int clcdfb_of_init_display(struct clcd_fb *fb) return err; } + err = clcdfb_of_get_enable_gpio(&fb->dev->dev, panel, fb->panel); + if (err) + return err; + err = clcdfb_of_get_backlight(panel, fb->panel); if (err) return err; diff --git a/include/linux/amba/clcd.h b/include/linux/amba/clcd.h index 1035879..a9c6007 100644 --- a/include/linux/amba/clcd.h +++ b/include/linux/amba/clcd.h @@ -105,6 +105,7 @@ enum { }; struct backlight_device; +struct gpio_desc; struct clcd_panel { struct fb_videomode mode; @@ -119,6 +120,7 @@ struct clcd_panel { grayscale:1; unsigned int connector; struct backlight_device *backlight; + struct gpio_desc *enable_gpio; /* * If the B/R lines are switched between the CLCD * and the panel we need to know this and not try to