From patchwork Mon Feb 13 00:13:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9568657 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D3DA60572 for ; Mon, 13 Feb 2017 00:13:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03BB72810E for ; Mon, 13 Feb 2017 00:13:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB3AC28135; Mon, 13 Feb 2017 00:13:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 942612810E for ; Mon, 13 Feb 2017 00:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbdBMANy (ORCPT ); Sun, 12 Feb 2017 19:13:54 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35958 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdBMANx (ORCPT ); Sun, 12 Feb 2017 19:13:53 -0500 Received: by mail-pf0-f195.google.com with SMTP id 19so6212180pfo.3; Sun, 12 Feb 2017 16:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=NnEUGS6R8Dk2FluR01tle/Yj7scwDXEPxOQGsk7IEmo=; b=cYJmcuVCXyS0ScIb8iUVqQi3ycI7JJjl9dg50zJE9b6uulnLaihSJwLhARqDdjWZO2 eh6tIv6d/cn3m19LxAUB+Cg84mslDga3O9GqiSPrsI3RoasZGY5VmQbLOykMYVZbMnBf WC8G6e9qVc4cToRDsCIMVp/TUvOnjdr1+YbNyqKaapzNs35gJ2Hf0iV9fdC8chzrt4on RFQ1d5k5jPeRb1++WSMTIOVDcy6M9XoUiY4dxoRgKFDCE7PbkzXyCz4DtSWggDgd6bn2 KADvoe9lsX5L9xcElbgpFFG40IJpVew7Sy/NKfBR01qQyFlTx02ly9VmXldRJfSd/X9i zEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=NnEUGS6R8Dk2FluR01tle/Yj7scwDXEPxOQGsk7IEmo=; b=o7vwaGz+igBdVVTFYh7/0HXNVp2wwb44mfvmcO6bH8851twPvFnl9G0BHuRcrAWiF9 DFjPhSyHCI+JNeDKtOSfYpondejDkPwTXLOVNSnspDKR0Zt/oooXQKTon0+KaAh/TR0z mgwifG/eeHN7VnMcKDNGFJsM0Sg0QwqJlv3o2m6lfpRzDXNn+n9gZZN2jLCCwdmqKtTu ZtBtWquv0mbvKKLLeYRJW2lTWN9VsB77H+l0HGl90F7qsErs+/o0J79W2fRusUx/q8Hn 2IvIBoA/8O+u2WZSrVlEmai/sB+WzDTNoaX59G2JCNkX9JoaykxDuqpgiUUor/92ohyj Cuog== X-Gm-Message-State: AMke39kT0H+BNDLefHfB+I1pduR8hp4+6Y5a5mfXS+7AQwUQ8K96+sMSB5eozbSi9wnhSg== X-Received: by 10.84.217.212 with SMTP id d20mr1461429plj.53.1486944832860; Sun, 12 Feb 2017 16:13:52 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:7531:2f4f:130e:34ea]) by smtp.gmail.com with ESMTPSA id p17sm10552862pfi.97.2017.02.12.16.13.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 12 Feb 2017 16:13:52 -0800 (PST) Date: Sun, 12 Feb 2017 16:13:49 -0800 From: Dmitry Torokhov To: Bartlomiej Zolnierkiewicz Cc: "Maciej W. Rozycki" , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: remove incorrect __exit markups Message-ID: <20170213001349.GA1839@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Also pmagb(a|b)fb_erase_cursor() are called from non __init codepaths, so they should not be marked as __init either. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/pmag-ba-fb.c | 6 +++--- drivers/video/fbdev/pmagb-b-fb.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/pmag-ba-fb.c b/drivers/video/fbdev/pmag-ba-fb.c index 5872bc4af3ce..1fd02f40708e 100644 --- a/drivers/video/fbdev/pmag-ba-fb.c +++ b/drivers/video/fbdev/pmag-ba-fb.c @@ -129,7 +129,7 @@ static struct fb_ops pmagbafb_ops = { /* * Turn the hardware cursor off. */ -static void __init pmagbafb_erase_cursor(struct fb_info *info) +static void pmagbafb_erase_cursor(struct fb_info *info) { struct pmagbafb_par *par = info->par; @@ -235,7 +235,7 @@ static int pmagbafb_probe(struct device *dev) return err; } -static int __exit pmagbafb_remove(struct device *dev) +static int pmagbafb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -270,7 +270,7 @@ static struct tc_driver pmagbafb_driver = { .name = "pmagbafb", .bus = &tc_bus_type, .probe = pmagbafb_probe, - .remove = __exit_p(pmagbafb_remove), + .remove = pmagbafb_remove, }, }; diff --git a/drivers/video/fbdev/pmagb-b-fb.c b/drivers/video/fbdev/pmagb-b-fb.c index 0822b6f8dddc..46e96c451506 100644 --- a/drivers/video/fbdev/pmagb-b-fb.c +++ b/drivers/video/fbdev/pmagb-b-fb.c @@ -133,7 +133,7 @@ static struct fb_ops pmagbbfb_ops = { /* * Turn the hardware cursor off. */ -static void __init pmagbbfb_erase_cursor(struct fb_info *info) +static void pmagbbfb_erase_cursor(struct fb_info *info) { struct pmagbbfb_par *par = info->par; @@ -353,7 +353,7 @@ static int pmagbbfb_probe(struct device *dev) return err; } -static int __exit pmagbbfb_remove(struct device *dev) +static int pmagbbfb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -388,7 +388,7 @@ static struct tc_driver pmagbbfb_driver = { .name = "pmagbbfb", .bus = &tc_bus_type, .probe = pmagbbfb_probe, - .remove = __exit_p(pmagbbfb_remove), + .remove = pmagbbfb_remove, }, };