From patchwork Sat Feb 25 19:24:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9591877 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 84E8D60416 for ; Sat, 25 Feb 2017 19:24:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F97028174 for ; Sat, 25 Feb 2017 19:24:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6330428516; Sat, 25 Feb 2017 19:24:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E81728174 for ; Sat, 25 Feb 2017 19:24:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbdBYTYu (ORCPT ); Sat, 25 Feb 2017 14:24:50 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34145 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdBYTYt (ORCPT ); Sat, 25 Feb 2017 14:24:49 -0500 Received: by mail-pg0-f67.google.com with SMTP id s67so7466637pgb.1; Sat, 25 Feb 2017 11:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=JlO0W09784ngD6aQA+oifA6ARUUMPXst7IwJWpTu7Gg=; b=UEGxQFfFVerZYaQCUlhDhtFveFzRxfF0h60rMD76CbFMU89zVmL0Kw7Iq2QjYPO5Kh 91MlN0TYDQM+9sntj2tyED+G9trf5rsEeSPJq6g2XBE/Xy6/8EoFOZp6jXTSaJeLruxO XrpBKfMWKwLv9P4xZ/RvdH83uVADASsIyQ0qP786OiU2i77Akc9V3FekKQmqsK1fPy/i epc6oJD8+HBg3DaVN+C70xm4nHVWocmLqHu1v2df1j+GN4shWYNJfZyUZib2hnblxCZs O2QtfmsZhaAg8zPDjlJkhenbP4TxJnv0iYMCj1ueSGdCoo4impZ02rnMDdUS5Qg8hw/4 KAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=JlO0W09784ngD6aQA+oifA6ARUUMPXst7IwJWpTu7Gg=; b=a80aeTaJEW0RZKTdBjwYPNi/Q05tvnFZoWA5TlkwOSRflsNZTVbVsjV8UGsM0zNoRb ssBh9iM8cdYBPSUoUvwZg2N8FMuWk4s5Z4GTxzIEnMf3GiYGBF5koe/4hv/B8dgTRhY+ Hqcefqac1wtB90mtAXXhHpPg+im6Fe/6sR8CaO1fIOcBU0PuXysizRij6ALXXkI6/fpL 9ZDbISEBoT8nSbw/U8mzu1b/AOONWeq8qAXYIVwkTH163/OfMgdZmQK+HfNeJwsg4tiA by8y2PUpYwE91CtOZgRRHA7fruQBuknQ2gk8n18CtGVRQ+4gV10ZVjNCtm6li3H7vkj0 q/bw== X-Gm-Message-State: AMke39ncESUrEozeNeBqDvYWtC5Igq1NKz22dpCcQe0IMSjcMiYfo9xAeFhEUey3NCE/RA== X-Received: by 10.98.71.7 with SMTP id u7mr11518695pfa.76.1488050688789; Sat, 25 Feb 2017 11:24:48 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:4119:e930:8ae5:beb]) by smtp.gmail.com with ESMTPSA id 80sm611634pgd.39.2017.02.25.11.24.47 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 25 Feb 2017 11:24:48 -0800 (PST) Date: Sat, 25 Feb 2017 11:24:46 -0800 From: Dmitry Torokhov To: Bartlomiej Zolnierkiewicz Cc: "Maciej W. Rozycki" , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: pmag-ba-fb: remove incorrect __exit markups Message-ID: <20170225192446.GA12502@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/pmag-ba-fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pmag-ba-fb.c b/drivers/video/fbdev/pmag-ba-fb.c index 5872bc4af3ce..f49317f137ec 100644 --- a/drivers/video/fbdev/pmag-ba-fb.c +++ b/drivers/video/fbdev/pmag-ba-fb.c @@ -235,7 +235,7 @@ static int pmagbafb_probe(struct device *dev) return err; } -static int __exit pmagbafb_remove(struct device *dev) +static int pmagbafb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -270,7 +270,7 @@ static struct tc_driver pmagbafb_driver = { .name = "pmagbafb", .bus = &tc_bus_type, .probe = pmagbafb_probe, - .remove = __exit_p(pmagbafb_remove), + .remove = pmagbafb_remove, }, };