From patchwork Sat Feb 25 19:25:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9591881 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9846760416 for ; Sat, 25 Feb 2017 19:25:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89A5F28174 for ; Sat, 25 Feb 2017 19:25:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C14728516; Sat, 25 Feb 2017 19:25:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35F2C28174 for ; Sat, 25 Feb 2017 19:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbdBYTZP (ORCPT ); Sat, 25 Feb 2017 14:25:15 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35572 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdBYTZP (ORCPT ); Sat, 25 Feb 2017 14:25:15 -0500 Received: by mail-pg0-f66.google.com with SMTP id 1so7454029pgz.2; Sat, 25 Feb 2017 11:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=UA1IU0UuMp4J67oc+XynWefVDdM5Npu8YZghQ6Gvbss=; b=Y64dPnMHvdHzgtwwavojPh90bGdCzRLphPEHhuDVO39r/ZKdnNstlPWJkhHleI5T84 s1ouAWattv1UxSNUsTrsGX01f42crV15zwgAFmvGOnNgSGeHaqNkDNdt7VSe+S7KjlTi JLdFWwpQMr4DvqvuIsAYb9hGPGp6TodZz7uvhO2C4GFWA7g7IvYl+a06rZJOHY9lrUrz hZUssJCa/sL1CerAqxWQ1Lt1RrJI/jseBqLy22c6zbc63riTIOOMiIVLSQE4DScfPvhG N8sGR3reYFdgRzc3hGTPuTlsMocTqJUYhbTdbW0vMQE9otGeP5V5BkT+V/az4zVYuOAB KxRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=UA1IU0UuMp4J67oc+XynWefVDdM5Npu8YZghQ6Gvbss=; b=MhGElfF4FFqyZfr8d0MiqaBk3QInsttSPQz+CdJBnGqBKKIromcrg14H95i3ytjlwa GAcwtUWYoqsdhrts33+FIWOvR0Pl3rZqOw8dy5m9bPM6tlT+lEWdSCNwvvUqCT36MpY+ NVr71ISKjaAg9JKpJA86iC3Zn+40lv72KA9ZkWmqEKmk3agMM2u8m24wzt7tyiXQiyL9 2yASTvI+4Q3b2B5lvEXoDxW3t/FZuNks3ifWHky9ZVF+tWUqNUNggETECev/KaMVgyC5 jpfC8AzIEyHa9TI6WvDsOqJF4+rhwM2/owePV4/eYwhP885ZyQESrhb6aY7zzS9RIkKA VEpQ== X-Gm-Message-State: AMke39nQ5+qfRymNFwUWXqY4Rq+oFkd+cKZRGyxVEu7Crx2b/OFc1RVr5kyvX5KWeoFrhw== X-Received: by 10.84.231.134 with SMTP id g6mr13168416plk.110.1488050714041; Sat, 25 Feb 2017 11:25:14 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:4119:e930:8ae5:beb]) by smtp.gmail.com with ESMTPSA id q23sm221820pfg.63.2017.02.25.11.25.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 25 Feb 2017 11:25:13 -0800 (PST) Date: Sat, 25 Feb 2017 11:25:11 -0800 From: Dmitry Torokhov To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: pmagb-b-fb: remove incorrect __exit markups Message-ID: <20170225192511.GA12591@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/pmagb-b-fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pmagb-b-fb.c b/drivers/video/fbdev/pmagb-b-fb.c index 0822b6f8dddc..2ae88b4e86b0 100644 --- a/drivers/video/fbdev/pmagb-b-fb.c +++ b/drivers/video/fbdev/pmagb-b-fb.c @@ -353,7 +353,7 @@ static int pmagbbfb_probe(struct device *dev) return err; } -static int __exit pmagbbfb_remove(struct device *dev) +static int pmagbbfb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -388,7 +388,7 @@ static struct tc_driver pmagbbfb_driver = { .name = "pmagbbfb", .bus = &tc_bus_type, .probe = pmagbbfb_probe, - .remove = __exit_p(pmagbbfb_remove), + .remove = pmagbbfb_remove, }, };