From patchwork Wed Mar 1 23:31:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9599267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3706A600CB for ; Thu, 2 Mar 2017 00:08:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2857B28543 for ; Thu, 2 Mar 2017 00:08:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CB9028565; Thu, 2 Mar 2017 00:08:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A977828543 for ; Thu, 2 Mar 2017 00:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbdCBAID (ORCPT ); Wed, 1 Mar 2017 19:08:03 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35724 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdCBAHy (ORCPT ); Wed, 1 Mar 2017 19:07:54 -0500 Received: by mail-pf0-f194.google.com with SMTP id 67so504447pfg.2; Wed, 01 Mar 2017 16:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=CK/53oKa3Alrcxdcd2dNVYB4dw8sDelOLHTtjqbfwZs=; b=K/XwiBDYD8hu4RNeQvABwSjfW/OswSCiK6/qhbyT0fOdGnmAW0zgRxUu2d5rS7W1El iPGDlQZFm+OVCXG9CR912XoDIHZSTbEDJUsx0eOZUQmHB2Ml132OlPE9WLM3hbvg2Dzw MMkxZmcaUcDLWw+/BK3iJ0ULOAH0LarSUTTzDBdwYmg9NYBykYJ284/SeUCesIoRofNq FCO8mEF1MdLsr4ijDOmvIY29+PQFpGL6yeYhGjjvjaM18zJk2++6ly8nlKszx5WmDvFA rmatSZRzoOIlU2geuHlqs8xDSfiMmfFj6MefQKzpvg9VdWNlYh3A63fLdTJo7ewhEX5c M61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=CK/53oKa3Alrcxdcd2dNVYB4dw8sDelOLHTtjqbfwZs=; b=Tbk6c3QtbLj4bgRGyBnM2gewpNKBmhtRU9M//0bUlP6IajYIOO7Io7Emqdmkj07v9p 0030uvJy79/zeuYOSTsy7tqCJ+2zMj9XMEdrZzQPnAQ3zckqkr3Qdrun8xm4SdTKPVWn DAv3LrzILeAuubQiTWUGqo5aYp+8YU04RqNzmLQIuMw2uLFNBLnV152MtZ4DK7HpbxzC mMbMPGEH5kCgWsKAPgiPHeNCrw3/5ZErg18RHa4/GXvb6eqakU9AqG9O8WTXhy+Yj9Jc bOUFMQ57MegsLKF8B+NuqU/16slHwXM5CDqTN9LzKAiHyezaNBe/IJ0VqA7Te4qdv0kK IP8g== X-Gm-Message-State: AMke39nb6rvE6NTypIWhfbPnR13qATGplixHOQfIwiXVqqLEkveysp4QNzw5+BksYNzkig== X-Received: by 10.99.152.65 with SMTP id l1mr12095025pgo.28.1488411072024; Wed, 01 Mar 2017 15:31:12 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:f18a:a6c4:f29d:1ab0]) by smtp.gmail.com with ESMTPSA id y21sm12679583pgh.52.2017.03.01.15.31.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Mar 2017 15:31:11 -0800 (PST) Date: Wed, 1 Mar 2017 15:31:09 -0800 From: Dmitry Torokhov To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups Message-ID: <20170301233109.GA8563@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/pmag-aa-fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pmag-aa-fb.c b/drivers/video/fbdev/pmag-aa-fb.c index ffe2dd482f84..39922f072db4 100644 --- a/drivers/video/fbdev/pmag-aa-fb.c +++ b/drivers/video/fbdev/pmag-aa-fb.c @@ -247,7 +247,7 @@ static int pmagaafb_probe(struct device *dev) return err; } -static int __exit pmagaafb_remove(struct device *dev) +static int pmagaafb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -280,7 +280,7 @@ static struct tc_driver pmagaafb_driver = { .name = "pmagaafb", .bus = &tc_bus_type, .probe = pmagaafb_probe, - .remove = __exit_p(pmagaafb_remove), + .remove = pmagaafb_remove, }, };