From patchwork Thu Mar 2 01:31:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9599441 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B2ED7600CB for ; Thu, 2 Mar 2017 01:42:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A225E2236A for ; Thu, 2 Mar 2017 01:42:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 93594252D5; Thu, 2 Mar 2017 01:42:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 446642236A for ; Thu, 2 Mar 2017 01:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbdCBBmJ (ORCPT ); Wed, 1 Mar 2017 20:42:09 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36012 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbdCBBmG (ORCPT ); Wed, 1 Mar 2017 20:42:06 -0500 Received: by mail-pf0-f194.google.com with SMTP id j5so5097569pfb.3; Wed, 01 Mar 2017 17:42:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Mhjx8B+HlrUeIR03rqdd+sH0fMX/EflVa/mM8EmYIn8=; b=lrk3O5JyP5Iis/Xj0yLolHPdT/fZ8lMO7n/sVR50lj/5vWj7nJhRFvA6p5y1npX4IT xmTLDKMpRRuhKtoHfSbvTmYbn8xo2+OE32/9+FCTAUQz7ygtTWMDo3Yg814ew78QBCBc TepTM1GKmzMJyuutHuuvWG5gXU185AGAjQDWetHNG2/1XlXOg4q2AC1OzJqo2prohxEf aAJmQhu962xWyKoGxYB37LmINAy8VRbOgXpd4WQ8mFpnzkFkToHNUg1zYe8NX0As0Uo4 jIXfCRW558fZxOtbucGdvX4LAMQC2KaR3e9DAJ6K0Z8eJ7jmA41jk7VayRAldI7trvdj GZ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=Mhjx8B+HlrUeIR03rqdd+sH0fMX/EflVa/mM8EmYIn8=; b=hq/5Aach4yICUB8EJEWtFJH1dSk6+yzLFYEKugTTa96cot3xlPEilEz2qDIjQhudlo ar86F/jJOKzZvTwwKrha9rQfNfAzlAGLjPtm1P/oj11vp7tARCJ5C4xKJ7XJ0vYf3AKe O8iASZ26x0trr/z7We/qai5X6OPbrq2nae4PUyWh3Q8m23Mc2taT/kkWvlyqT+B1COJX SxTMgcxNt2meZSROhDWS1V0Rd9qk2pDva8dkHcUXoRbUt5kuc6YFA2XDNP2ijcBxL8uz Z7bZWimra8EGlSxY73Vk9d26IrLxr3m9EFwdtEwE7CQNHmoraw9B5ESoP4zjare9gXWQ fd+w== X-Gm-Message-State: AMke39kwRJxMvE578nUOzLMMpIV0caSc2ZSach3BicfPEXYj7APoKJ0fvR2LkEB3UPDYbg== X-Received: by 10.99.123.75 with SMTP id k11mr12302732pgn.17.1488418263815; Wed, 01 Mar 2017 17:31:03 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:f18a:a6c4:f29d:1ab0]) by smtp.gmail.com with ESMTPSA id y184sm12853555pfg.86.2017.03.01.17.31.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Mar 2017 17:31:03 -0800 (PST) Date: Wed, 1 Mar 2017 17:31:01 -0800 From: Dmitry Torokhov To: Antonino Daplas Cc: Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: i810: remove incorrect __exit markups Message-ID: <20170302013101.GA2047@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/i810/i810_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c index 483ab2592d0c..2488baab7c89 100644 --- a/drivers/video/fbdev/i810/i810_main.c +++ b/drivers/video/fbdev/i810/i810_main.c @@ -81,7 +81,7 @@ static u32 voffset; static int i810fb_cursor(struct fb_info *info, struct fb_cursor *cursor); static int i810fb_init_pci(struct pci_dev *dev, const struct pci_device_id *entry); -static void __exit i810fb_remove_pci(struct pci_dev *dev); +static void i810fb_remove_pci(struct pci_dev *dev); static int i810fb_resume(struct pci_dev *dev); static int i810fb_suspend(struct pci_dev *dev, pm_message_t state); @@ -128,7 +128,7 @@ static struct pci_driver i810fb_driver = { .name = "i810fb", .id_table = i810fb_pci_tbl, .probe = i810fb_init_pci, - .remove = __exit_p(i810fb_remove_pci), + .remove = i810fb_remove_pci, .suspend = i810fb_suspend, .resume = i810fb_resume, }; @@ -2123,7 +2123,7 @@ static void i810fb_release_resource(struct fb_info *info, } -static void __exit i810fb_remove_pci(struct pci_dev *dev) +static void i810fb_remove_pci(struct pci_dev *dev) { struct fb_info *info = pci_get_drvdata(dev); struct i810fb_par *par = info->par;