From patchwork Fri Mar 10 21:56:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi X-Patchwork-Id: 9618045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B97E5604DD for ; Fri, 10 Mar 2017 21:57:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A37C7223B2 for ; Fri, 10 Mar 2017 21:57:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 987EE2723E; Fri, 10 Mar 2017 21:57:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2238423B23 for ; Fri, 10 Mar 2017 21:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934134AbdCJV5O (ORCPT ); Fri, 10 Mar 2017 16:57:14 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34291 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934117AbdCJV5L (ORCPT ); Fri, 10 Mar 2017 16:57:11 -0500 Received: by mail-pg0-f68.google.com with SMTP id b5so11579447pgg.1; Fri, 10 Mar 2017 13:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5lXH+crviaZvYL5TIKj0YKyuSBdEvpJGtvWTX9MAqWc=; b=PNxn2ojso80WvAbgt03CHAd3hISVOc/6XFsOmto/SbLWeJusKCKN6nU7SE1p74Whac 09VyrVtPX1xJ3Z7AcnP6buQ8grnWBiDWWgfaYgji1Fou0daDWsq04dNHAE/MLmsmJ9Xh SWzNNa6KJUWgHAznCiCBtDDVN49LFJBP/MZ92Xb8xCbXbtWatJ8MempUleO477P1yEpo sEmtT7jQtNjcv0Rh++5KlynMSoSlrR6eNILvUaK1nCbTGl6XzAxYxH9nEZ6QrlH+MC/k 6i4yLn5FSJJAmo5UaVgYliHVPjs60jyghFPLCTrBlGrUKL6dyFU0xEUwDGQK7rX27Uh+ Sntg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5lXH+crviaZvYL5TIKj0YKyuSBdEvpJGtvWTX9MAqWc=; b=dSW37ZbKO4B469tyqVOQWPcF0dfaGHxLyrR0bwFgsMm49RA88QAkHGvWjLNw68QYZ1 BbyQ+JVsoBwwBKPGeRfAed2uHcOfolMEiG5f8813qsj0+Xfo+FLtBVNI8Ax34otZUikN 5Hqk2dIiQq4/3Tkz/pcGR43E1J5sy24I0MT5+ZMv24fWvRAIAXvGTjGDdn54bN6pMCxJ 84tHvd625iBlpI2aM36Y7ziamC0FmZN8dyqMJiza/AUqijxP3I5PnWE0lovCJ4QLBvs2 AW+3M8RzqU3a/yVyCNFQWzzXTFEAOsqvV7fbAJVbII0RhhVfNPWpz3KFrP4UdmHVdCsu m0iw== X-Gm-Message-State: AMke39kBqGLC2F72J49fjTdw05FE9MvS6O2dFi/oaoJBbi7akjwCTMMwFhXHJJRTDloNCw== X-Received: by 10.84.177.164 with SMTP id x33mr28345109plb.75.1489183029796; Fri, 10 Mar 2017 13:57:09 -0800 (PST) Received: from arushi-HP-Pavilion-Notebook ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id 128sm20405876pfe.23.2017.03.10.13.57.08 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Mar 2017 13:57:08 -0800 (PST) From: Arushi Singhal To: outreachy-kernel@googlegroups.com Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Arushi Singhal Subject: [PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name Date: Sat, 11 Mar 2017 03:26:55 +0530 Message-Id: <20170310215657.7069-2-arushisinghal19971997@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170310215657.7069-1-arushisinghal19971997@gmail.com> References: <20170310215657.7069-1-arushisinghal19971997@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/ddk750_power.h | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h index e2a3f84ca4c5..609bf742efff 100644 --- a/drivers/staging/sm750fb/ddk750_display.h +++ b/drivers/staging/sm750fb/ddk750_display.h @@ -102,6 +102,6 @@ typedef enum _disp_output_t { } disp_output_t; -void ddk750_setLogicalDispOut(disp_output_t); +void ddk750_setLogicalDispOut(disp_output_t output); #endif diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 2183e664cf4b..6d204b8b4a01 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -34,6 +34,6 @@ typedef struct _mode_parameter_t { } mode_parameter_t; -int ddk750_setModeTiming(mode_parameter_t *, clock_type_t); +int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock); #endif diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index ec0b99d6a7ad..44c4fc587e96 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -14,7 +14,7 @@ DPMS_t; (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \ } -void ddk750_set_dpms(DPMS_t); +void ddk750_set_dpms(DPMS_t state); void sm750_set_power_mode(unsigned int powerMode); void sm750_set_current_gate(unsigned int gate); diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 306711ed55f9..5ea455dee949 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -184,7 +184,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) } int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); -int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *); +int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); void hw_sm750_initAccel(struct sm750_dev *); int hw_sm750_deWait(void); int hw_sm750le_deWait(void);