From patchwork Sat Mar 11 09:53:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi X-Patchwork-Id: 9618521 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 45F3660417 for ; Sat, 11 Mar 2017 09:53:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E8AD287AF for ; Sat, 11 Mar 2017 09:53:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23140287B9; Sat, 11 Mar 2017 09:53:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE39B287AF for ; Sat, 11 Mar 2017 09:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbdCKJxM (ORCPT ); Sat, 11 Mar 2017 04:53:12 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35187 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbdCKJxJ (ORCPT ); Sat, 11 Mar 2017 04:53:09 -0500 Received: by mail-pf0-f193.google.com with SMTP id 67so13426502pfg.2; Sat, 11 Mar 2017 01:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=sYEXOxvzPsgCCZkyPkCgexU+B50QrbkgP9VwVMl+hag=; b=um549LMk9Yi8HbwOt0mCgdOHMNOqK/DrZoxSe9D1klvowIrKbFyjyJ/LIinkTz62N+ vMJl2ZYuvIMQTSDhi/W5vn9okBp7u8ImMFJdBeuC4ctwVUXJJHGuQ2MImxOaXcFf4i45 x568VzxWflGr9Al5DVGj4NAUEraJdCU3T8zE46LdVae6y5pXQdn+EOttsJiBpN3maGrV kwxnH1inNpTZUHcdyoTGOEjCIcCLpJGyKIOexY5i/hdTYbAH49lAS/aXSxeGnLouhcIe hyqycDhPMV4jaiIA0W4BnySsN4mkEM7jz+8ZIvzCODGN4VmcLA28iL7+STVGKUuH80ZD twDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=sYEXOxvzPsgCCZkyPkCgexU+B50QrbkgP9VwVMl+hag=; b=hpBNj3JEuv7IOmilRdesfV4mKgoiNw+429w32GybpP7fnSLHje73/xo5Rf1dp7Y7LU Ii9lzFqLGUwNXYo5Vswi7CRwgDzI7kCtDJOgQ1X5fKDlp2DIS5t9CYsX2czBpXcfd4ep ObQkHjcztCDU1C8wEimz/+DThfAkYs+X/+CqVg2M8EFwjKZ5daRyMJ1A3jCRJbqTb+xf lva3kzZo8TB7nj/q45kJVopnCVkGvmpQocdQ9in9K2HJbxmp5uBrpTHBNXozvcJ4un0Q AM8hD2/pWcTM+vZcJBTR8an2DBkuUOGTkkgCLLOm/UARihLgPgPnEm1z5gtb1/CFugm/ Vizg== X-Gm-Message-State: AMke39lK4qBf/5TNsxRXKETeta2jJmhmh+9XiZVB7FJFo7kHlsXEpQDjxqz1mWVvkiwl1A== X-Received: by 10.98.8.74 with SMTP id c71mr25731775pfd.42.1489225987557; Sat, 11 Mar 2017 01:53:07 -0800 (PST) Received: from arushi-HP-Pavilion-Notebook ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id 73sm23235116pfj.31.2017.03.11.01.53.05 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Mar 2017 01:53:05 -0800 (PST) Date: Sat, 11 Mar 2017 15:23:03 +0530 From: Arushi Singhal To: sudipm.mukherjee@gmail.com Cc: Teddy Wang , outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: sm750fb: function prototype argument should have an identifier name Message-ID: <20170311095302.GA4037@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- changes in v2 -Add the identifier name of one more function prototype drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/ddk750_power.h | 2 +- drivers/staging/sm750fb/sm750.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h index e2a3f84ca4c5..609bf742efff 100644 --- a/drivers/staging/sm750fb/ddk750_display.h +++ b/drivers/staging/sm750fb/ddk750_display.h @@ -102,6 +102,6 @@ typedef enum _disp_output_t { } disp_output_t; -void ddk750_setLogicalDispOut(disp_output_t); +void ddk750_setLogicalDispOut(disp_output_t output); #endif diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 2183e664cf4b..6d204b8b4a01 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -34,6 +34,6 @@ typedef struct _mode_parameter_t { } mode_parameter_t; -int ddk750_setModeTiming(mode_parameter_t *, clock_type_t); +int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock); #endif diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index ec0b99d6a7ad..44c4fc587e96 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -14,7 +14,7 @@ DPMS_t; (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \ } -void ddk750_set_dpms(DPMS_t); +void ddk750_set_dpms(DPMS_t state); void sm750_set_power_mode(unsigned int powerMode); void sm750_set_current_gate(unsigned int gate); diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 306711ed55f9..f60565cae80c 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -184,8 +184,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) } int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); -int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *); -void hw_sm750_initAccel(struct sm750_dev *); +int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); +void hw_sm750_initAccel(struct sm750_dev *hw_sm750_initAccel); int hw_sm750_deWait(void); int hw_sm750le_deWait(void);