From patchwork Sun Mar 19 13:50:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi X-Patchwork-Id: 9632573 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 317AE602D6 for ; Sun, 19 Mar 2017 13:58:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23590284CF for ; Sun, 19 Mar 2017 13:58:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1828F284D1; Sun, 19 Mar 2017 13:58:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A94DC284CF for ; Sun, 19 Mar 2017 13:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbdCSN6a (ORCPT ); Sun, 19 Mar 2017 09:58:30 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34087 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbdCSN63 (ORCPT ); Sun, 19 Mar 2017 09:58:29 -0400 Received: by mail-pf0-f194.google.com with SMTP id o126so13902828pfb.1; Sun, 19 Mar 2017 06:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=+E7+07m6HGbsj3bvo58U+Z/NwXBug81zMx9uWx8DDKI=; b=TCg8/xWcCauCTN7ctOtkV6fcMzqmxTUOcoWPcKEeNh/uIdoWlmiCcyuQDhuNu2XApj CqrHlB6s1Z5FVh+9TJJpKNuvL4Y+ggoEF9HvatZlfXpBn9S4MHCdDI1aI0roOs+MWV5b GtF3Ps3V3AkAdC2t5R/+B8iU8kTvY7hlxpsV2tyWQoTsDggsg9ocl9Z8ESGa6QqaxOMv HcQJabZaYUvJpYJjuliBqvff5tDlPnzDDN7E5t5Zmzgu2F21cJ6N4HA1Ot5ewJMEwRfD ovLS+z+ccTuVRRFIwGGr5WW6Trd6x/1tdl5YHEgDWUeVwoOiSDg9aUeHwm4LPUSnFHMN eHKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=+E7+07m6HGbsj3bvo58U+Z/NwXBug81zMx9uWx8DDKI=; b=F2Gcqoz9aNyqhz30zEHUwK+Ds5X4E0kAi34uIFPN7cfSzEErZJuIdnjwRt1/i6IXA+ PsqNfWzF3n5R0AR4fldjXFFQkklZPVx99BUXknKgnkSOQBjoNbd2ynQ3sPoXgKNxDggG mdDZ11gedAKPz+lS2JRyOoAGXHfu0bzuEoQn76OVS/H+mI9DGex02dTo0piiT60mj/Gw nyxJuTB6KsZlP5bLyjvH3q7HqB4xqA8/YYWR5JiVb9KKyzFYXdpUmjnrbANDrJVKEnz6 zTPpMDXyqmnxWQMJsMkr1HwbJPq+C1iZoC+KGKk1wFNfD3q6HyXdYR6FtTJmjDBER1WE t5Tg== X-Gm-Message-State: AFeK/H2fPyhrVdtPlgqAK5VcrYtsD2GRuTkR+05wzU4IusWJ67hRQk1nNzwjJaj/YWemDg== X-Received: by 10.98.34.211 with SMTP id p80mr28077056pfj.174.1489931419279; Sun, 19 Mar 2017 06:50:19 -0700 (PDT) Received: from arushi-HP-Pavilion-Notebook ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id m6sm27416510pfm.22.2017.03.19.06.50.17 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 19 Mar 2017 06:50:18 -0700 (PDT) Date: Sun, 19 Mar 2017 19:20:13 +0530 From: Arushi Singhal To: sudipm.mukherjee@gmail.com Cc: Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH v5] staging: sm750fb: Remove typedefs from structures and enum Message-ID: <20170319135013.GA1349@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes typedefs from structure and enum and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal --- changes in v5 - make the commit message more relevant. - remove prefix and suffix underscore. drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.h | 18 ++++++++---------- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 5f18ce4d10de..61d339437764 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -12,7 +12,7 @@ * HW only supports 7 predefined pixel clocks, and clock select is * in bit 29:27 of Display Control register. */ -static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, unsigned long dispControl) +static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, unsigned long dispControl) { unsigned long x, y; @@ -72,7 +72,7 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, } /* only timing related registers will be programed */ -static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *pll) +static int programModeRegisters(struct mode_parameter *pModeParam, struct pll_value *pll) { int ret = 0; int cnt = 0; @@ -207,7 +207,7 @@ static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value * return ret; } -int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock) +int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock) { struct pll_value pll; unsigned int uiActualPixelClk; diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 6d204b8b4a01..07cb3f14d1ce 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -3,26 +3,25 @@ #include "ddk750_chip.h" -typedef enum _spolarity_t { +enum spolarity { POS = 0, /* positive */ NEG, /* negative */ -} -spolarity_t; +}; -typedef struct _mode_parameter_t { +struct mode_parameter { /* Horizontal timing. */ unsigned long horizontal_total; unsigned long horizontal_display_end; unsigned long horizontal_sync_start; unsigned long horizontal_sync_width; - spolarity_t horizontal_sync_polarity; + enum spolarity horizontal_sync_polarity; /* Vertical timing. */ unsigned long vertical_total; unsigned long vertical_display_end; unsigned long vertical_sync_start; unsigned long vertical_sync_height; - spolarity_t vertical_sync_polarity; + enum spolarity vertical_sync_polarity; /* Refresh timing. */ unsigned long pixel_clock; @@ -30,10 +29,9 @@ typedef struct _mode_parameter_t { unsigned long vertical_frequency; /* Clock Phase. This clock phase only applies to Panel. */ - spolarity_t clock_phase_polarity; -} -mode_parameter_t; + enum spolarity clock_phase_polarity; +}; -int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock); +int ddk750_setModeTiming(struct mode_parameter *parm, clock_type_t clock); #endif diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index fab3fc9c8330..baf1bbdc92ff 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -252,7 +252,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, { int ret, fmt; u32 reg; - mode_parameter_t modparm; + struct mode_parameter modparm; clock_type_t clock; struct sm750_dev *sm750_dev; struct lynxfb_par *par;