From patchwork Sun Mar 19 15:49:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi X-Patchwork-Id: 9632695 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7BD596020B for ; Sun, 19 Mar 2017 15:49:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5845128356 for ; Sun, 19 Mar 2017 15:49:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A33F2842C; Sun, 19 Mar 2017 15:49:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFC5228356 for ; Sun, 19 Mar 2017 15:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbdCSPts (ORCPT ); Sun, 19 Mar 2017 11:49:48 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36652 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbdCSPtr (ORCPT ); Sun, 19 Mar 2017 11:49:47 -0400 Received: by mail-pf0-f193.google.com with SMTP id r137so10262694pfr.3; Sun, 19 Mar 2017 08:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=vzyL1rf90Awde51aHQ5TxVQyUsN5DQaTs4mnfPhgIec=; b=GROfJypxJz0It28H8sCvryL5hrJvxwCUrOs/LSE9XdKeCP7tmhquJcoKAamM1Lixv7 qcYqojjYEOaRogvXB4xa0GV79K4YV5yOCsZQ3joPyezbmJLziGrrNsTP5ca3xwfJ1qZq N01dkSQUA1lLbaLpS/wrpLmnHbxo+DhxmGvQbAz/8KDoZEADuXiWUZYT1XUHzUGpeWlA NTS7jqE2cCSfOdqyJI+EVFoUbXSEoyTNTDkAQ/9jeL//NH1qrdUszDwpT1KmJ2PddFmm qySKR8+vywgYey/IWB1mVI9QpCoqnOSoCerEzgI9QY2apqJpxfIUe8nrxk73AC5geVFQ tAnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=vzyL1rf90Awde51aHQ5TxVQyUsN5DQaTs4mnfPhgIec=; b=Mwvk2ntazGtTMJK8yYvY1IXTKpej1a/zfMcprjmj4dZsPw4Q404mSHj5bIAE3FlYTH pSbYTCBMUemyLTLoAoIaXqa9ma/HeZMcIZe4SJoVYrq+XcS5LWfQF8oh+46/kokkroam hWCcjObdxm8r9DIsINfczWh2GcBIWHYyc6+mItuIoEZXQeHg8j++cxEeQ3KftTZ1+mXF CBo6D0jm0D2fzCiAsptzaw6RngW2vjcmHqQjsuc91JYGUXBMmxkQY5iuRq5m0npB5Wjz FdDCA6WcWXveZlQjUcw/pzCIHtwtVLfmLmV+ZCxvOGVAW9dkp3HUqW0XRdpwSeY8Jwkn vZRg== X-Gm-Message-State: AFeK/H33TwxXe2eYgo6kLMAO51cnKWKU7siBuT5wVgePFc8hMWRZzWQx2JbcK0erGM7KGA== X-Received: by 10.99.169.17 with SMTP id u17mr26074914pge.191.1489938564961; Sun, 19 Mar 2017 08:49:24 -0700 (PDT) Received: from arushi-HP-Pavilion-Notebook ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id v9sm27885291pfg.133.2017.03.19.08.49.22 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 19 Mar 2017 08:49:23 -0700 (PDT) Date: Sun, 19 Mar 2017 21:19:20 +0530 From: Arushi Singhal To: sudipm.mukherjee@gmail.com Cc: Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH v4] staging: sm750fb: Code readability is improved Message-ID: <20170319154920.GA12736@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP New variables are added to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v4 -try to make the code much more readable. - defined the variable at the top of a block. --- drivers/staging/sm750fb/ddk750_mode.c | 57 +++++++++++++++++++---------------- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index eea5aef2956f..6517e770e0a7 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -76,38 +76,43 @@ static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value * { int ret = 0; int cnt = 0; - unsigned int tmp, reg; + unsigned int tmp, reg, temp; if (pll->clockType == SECONDARY_PLL) { /* programe secondary pixel clock */ poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll)); - poke32(CRT_HORIZONTAL_TOTAL, - (((pModeParam->horizontal_total - 1) << - CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & - CRT_HORIZONTAL_TOTAL_TOTAL_MASK) | - ((pModeParam->horizontal_display_end - 1) & - CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK)); - - poke32(CRT_HORIZONTAL_SYNC, - ((pModeParam->horizontal_sync_width << - CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & - CRT_HORIZONTAL_SYNC_WIDTH_MASK) | - ((pModeParam->horizontal_sync_start - 1) & - CRT_HORIZONTAL_SYNC_START_MASK)); - poke32(CRT_VERTICAL_TOTAL, - (((pModeParam->vertical_total - 1) << - CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & - CRT_VERTICAL_TOTAL_TOTAL_MASK) | - ((pModeParam->vertical_display_end - 1) & - CRT_VERTICAL_TOTAL_DISPLAY_END_MASK)); + temp = (pModeParam->horizontal_total - 1) << + CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT; + temp = temp & CRT_HORIZONTAL_TOTAL_TOTAL_MASK; + temp = temp | ((pModeParam->horizontal_display_end - 1) & + CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK); - poke32(CRT_VERTICAL_SYNC, - ((pModeParam->vertical_sync_height << - CRT_VERTICAL_SYNC_HEIGHT_SHIFT) & - CRT_VERTICAL_SYNC_HEIGHT_MASK) | - ((pModeParam->vertical_sync_start - 1) & - CRT_VERTICAL_SYNC_START_MASK)); + poke32(CRT_HORIZONTAL_TOTAL, temp); + + temp = (pModeParam->horizontal_sync_width << + CRT_HORIZONTAL_SYNC_WIDTH_SHIFT); + temp = temp & CRT_HORIZONTAL_SYNC_WIDTH_MASK; + temp = temp | ((pModeParam->horizontal_sync_start - 1) & + CRT_HORIZONTAL_SYNC_START_MASK); + + poke32(CRT_HORIZONTAL_SYNC, temp); + + temp = (pModeParam->vertical_total - 1) << + CRT_VERTICAL_TOTAL_TOTAL_SHIFT; + temp = temp & CRT_VERTICAL_TOTAL_TOTAL_MASK; + temp = temp | ((pModeParam->vertical_display_end - 1) & + CRT_VERTICAL_TOTAL_DISPLAY_END_MASK); + + poke32(CRT_VERTICAL_TOTAL, temp); + + temp = pModeParam->vertical_sync_height << + CRT_VERTICAL_SYNC_HEIGHT_SHIFT; + temp = temp & CRT_VERTICAL_SYNC_HEIGHT_MASK; + temp = temp | ((pModeParam->vertical_sync_start - 1) & + CRT_VERTICAL_SYNC_START_MASK); + + poke32(CRT_VERTICAL_SYNC, temp); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; if (pModeParam->vertical_sync_polarity)