From patchwork Fri May 5 19:47:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9714323 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4030602B9 for ; Fri, 5 May 2017 19:48:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B25DC2869A for ; Fri, 5 May 2017 19:48:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A51F0286B3; Fri, 5 May 2017 19:48:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9202D2869A for ; Fri, 5 May 2017 19:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683AbdEETsh (ORCPT ); Fri, 5 May 2017 15:48:37 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58169 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755609AbdEETse (ORCPT ); Fri, 5 May 2017 15:48:34 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MWbfO-1dZpd13MDK-00Xb2F; Fri, 05 May 2017 21:48:29 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann , Alexander Stein , Tomi Valkeinen , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard Subject: [PATCH 3.16-stable 62/87] video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT Date: Fri, 5 May 2017 21:47:20 +0200 Message-Id: <20170505194745.3627137-63-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:gI7FeWPIiWPvGH7/9y7SQWaMqpT2hISPSHpFcGNiIqPJeW5Z5NN iYOxq4vv+ii5kK8ctaYa/D3W89HHPu8sPRSOz0tFcERkGjQhxJoxF8LfgarIEtbmvnsOp5L e073v4qWIWtN4w81ODOl5KEDPU+6TKI9d5IuqkYlPI9bQIRybRu+EovLLK1/fZ5JMAaKlG1 Fnf7IT0bK/Q1oOHMNJUpg== X-UI-Out-Filterresults: notjunk:1; V01:K0:tggABxA1BVs=:5nR7OnmbtfmZaiEXuiBhq+ H8NWRBz99gol4C0qvDvaujjOmu7Alg/4T80wNAVtB9160QUUvHaPCEjwETV+RjEH23ppJ46lk 42EiOTJDSKptCxjIPpkomiYjIZHIZx5fyLgSFqhWiuCmxk8aoMqXcYnzC/wPYDZJgFEn1st9Y 53Sei7FG5Bh0qC71IJmbTPjTcwKzTwE0Sm9D0vCP/b2vZukLiFzl+K0qht68uinksaZ1p+t9t 1M1WC7ftS0gRL73UCgY45LfhIdd2uvNLESGaIjsGbE0cfw5TzYs6iBC5ao/+yvX5aJNr6w7rq n6PIkgRfEqTB+apmuJWw6sIXRRw2COs7KR6txn/g684GlrTc/ZEldlObfrHCWKxiH3qhuZuvm dvKlNVH8rzq2BEuigTUunABSDiJSTAkjKjgsqU51WSHeyyj9jdvAlf01ZYAehaFsqi9UfppbY NRcLvnJ1pk21JIzVueAxK3m+2RQGeFCb98zutGEeiRm0nWWSm/VuyqUuMyMCmxpL6N8koV1io nwOVwbgBFvw9Ro335NVKssogfx1JL0q3hL9F4QGP7AyzlMb8/XXWrJWqd1YaskZmUkT8eJ10H luxs1MVgm584i5WnRhLJ/uiLQdt3FroX0cmV4TUBEbojxWJ7ItdV528pHBYFv84OfSDbAlJ/e lF2liedDi+y/goyQD4CTU+SN2tw1R645SmYmhQtm5Pelb40dA2dyvexbdcIHvmMbhjEc= Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit d06268f2c4867279648f499a31fba79a4066f3af upstream. Commit 7edaa761ee81b ("video: mx3fb: Add backlight control support") changed the mx3fb driver so it always selects the BACKLIGHT_CLASS_DEVICE symbol, but that is hidden behind BACKLIGHT_LCD_SUPPORT in Kconfig, so we get a Kconfig warning for multi_v5_defconfig, which doesn't have that: Warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI && EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT) This makes sure we always enable both symbols together for mx3fb, like we do for the other drivers that can't be built without backlight support. Note that a better solution would be to ensure the driver can work with or without backlight support. Signed-off-by: Arnd Bergmann Cc: Alexander Stein Cc: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org Cc: Jean-Christophe Plagniol-Villard Signed-off-by: Tomi Valkeinen Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index fac73ceb90e5..3b453c34f7a2 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2332,10 +2332,11 @@ config FB_MSM config FB_MX3 tristate "MX3 Framebuffer support" depends on FB && MX3_IPU + select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select BACKLIGHT_CLASS_DEVICE default y help This is a framebuffer device for the i.MX31 LCD Controller. So