| Message ID | 20170626220518.GA9369@embeddedgus (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Monday, June 26, 2017 05:05:18 PM Gustavo A. R. Silva wrote: > Value assigned to variable vdisplay at line 990 is overwritten > at line 1039 before it can be used. Also, variable assignment > at line 987 is the same as at line 1039. This makes such > variable assignments useless. > > Remove these variable assignments and the code related. > > Addresses-Covertity-ID: 1226900 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Patch queued for 4.13, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index 11026e7..3142d7f 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -984,12 +984,6 @@ static int aty_var_to_crtc(const struct fb_info *info, v_total <<= 1; } - vdisplay = yres; -#ifdef CONFIG_FB_ATY_GENERIC_LCD - if ((par->lcd_table != 0) && (crtc->lcd_gen_cntl & LCD_ON)) - vdisplay = par->lcd_height; -#endif - v_disp--; v_sync_strt--; v_sync_end--;
Value assigned to variable vdisplay at line 990 is overwritten at line 1039 before it can be used. Also, variable assignment at line 987 is the same as at line 1039. This makes such variable assignments useless. Remove these variable assignments and the code related. Addresses-Covertity-ID: 1226900 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/video/fbdev/aty/atyfb_base.c | 6 ------ 1 file changed, 6 deletions(-)